-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1744 Create ReportTable component #1758
Merged
diegoevangelisti
merged 5 commits into
feature/dashboard
from
#1744-ReportTable-component
Dec 20, 2019
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3ef8e11
Add ReportTable component
diegoevangelisti e4baf19
Merge branch 'feature/dashboard' into #1744-ReportTable-component
diegoevangelisti 329bed1
Merge branch 'feature/dashboard' into #1744-ReportTable-component
diegoevangelisti cc80e7b
Create component ReportTable
diegoevangelisti 7218d46
Add ListHeaderComponent prop
diegoevangelisti File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* eslint-disable react/prop-types */ | ||
/* eslint-disable react/forbid-prop-types */ | ||
/** | ||
* mSupply Mobile | ||
* Sustainable Solutions (NZ) Ltd. 2018 | ||
*/ | ||
|
||
import React from 'react'; | ||
import { StyleSheet, FlatList, View } from 'react-native'; | ||
import PropTypes from 'prop-types'; | ||
import { LIGHT_GREY } from '../../globalStyles'; | ||
import { ReportRow } from './ReportRow'; | ||
|
||
export const ReportTable = ({ rows, header }) => { | ||
const renderItem = ({ item, index }) => <ReportRow rowData={item} rowIndex={index} />; | ||
|
||
const renderHeader = () => <ReportRow rowData={header} rowIndex={0} />; | ||
|
||
// TODO: KeyExtractor should be altered to not use the index. | ||
return ( | ||
<View style={localStyles.container}> | ||
<FlatList | ||
data={rows} | ||
ListHeaderComponent={renderHeader} | ||
renderItem={renderItem} | ||
keyExtractor={(_, index) => `${index}`} | ||
/> | ||
</View> | ||
); | ||
}; | ||
|
||
ReportTable.propTypes = { | ||
header: PropTypes.array.isRequired, | ||
rows: PropTypes.array.isRequired, | ||
}; | ||
|
||
const localStyles = StyleSheet.create({ | ||
container: { | ||
backgroundColor: LIGHT_GREY, | ||
}, | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for the
renderItem
call? Theres some info here about that if you're interested jsx-eslint/eslint-plugin-react#2325There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have a problem with that indeed. If I declared them then
es-lint
says I'm not using them 😅