Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1744 Create ReportTable component #1758

Merged
merged 5 commits into from
Dec 20, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
41 changes: 41 additions & 0 deletions src/widgets/ReportTable/ReportTable.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/* eslint-disable react/prop-types */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for the renderItem call? Theres some info here about that if you're interested jsx-eslint/eslint-plugin-react#2325

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have a problem with that indeed. If I declared them then es-lint says I'm not using them 😅

/* eslint-disable react/forbid-prop-types */
/**
* mSupply Mobile
* Sustainable Solutions (NZ) Ltd. 2018
*/

import React from 'react';
import { StyleSheet, FlatList, View } from 'react-native';
import PropTypes from 'prop-types';
import { LIGHT_GREY } from '../../globalStyles';
import { ReportRow } from './ReportRow';

export const ReportTable = ({ rows, header }) => {
const renderItem = ({ item, index }) => <ReportRow rowData={item} rowIndex={index} />;

const renderHeader = () => <ReportRow rowData={header} rowIndex={0} />;

// TODO: KeyExtractor should be altered to not use the index.
return (
<View style={localStyles.container}>
<FlatList
data={rows}
ListHeaderComponent={renderHeader}
renderItem={renderItem}
keyExtractor={(_, index) => `${index}`}
/>
</View>
);
};

ReportTable.propTypes = {
header: PropTypes.array.isRequired,
rows: PropTypes.array.isRequired,
};

const localStyles = StyleSheet.create({
container: {
backgroundColor: LIGHT_GREY,
},
});