#1744 Create ReportTable component #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
josh-griffin
approved these changes
Dec 20, 2019
| export const ReportTable = ({ rows, header }) => { | ||
| const renderItem = ({ item, index }) => <ReportRow rowData={item} rowIndex={index} />; | ||
|
|
||
| const renderHeader = () => <ReportRow rowData={header} isHeader rowIndex={0} />; |
There was a problem hiding this comment.
This is fine, but there is also this prop on FlatList just for interest! https://facebook.github.io/react-native/docs/flatlist#listheadercomponent
There was a problem hiding this comment.
I made this change here: 7218d46
Hope it works, otherwise I can come back to previous stage :-) thanks for this!
There was a problem hiding this comment.
I think that should work!
| @@ -0,0 +1,37 @@ | |||
| /* eslint-disable react/prop-types */ | |||
There was a problem hiding this comment.
this is for the renderItem call? Theres some info here about that if you're interested jsx-eslint/eslint-plugin-react#2325
There was a problem hiding this comment.
Yes, I have a problem with that indeed. If I declared them then es-lint says I'm not using them 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1755
Change summary
Add
ReportTablecomponent to use together withReportRowandReportCellcomponents for visualising Table reports on the feature/dashboard.ReportRowandReportCellcomponents.Testing
Further testing will be taken once the feature/dashboard is intended to be merged into develop.
Related areas to think about
Codebase taken from past work: branch. Further changes may be taken into consideration.