New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix scroll restoration in the docs #34037
[core] Fix scroll restoration in the docs #34037
Conversation
createTheme as createLegacyModeTheme, | ||
unstable_createMuiStrictModeTheme as createStrictModeTheme, | ||
createTheme, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same module is exported under these two names since v5.
@@ -89,7 +89,7 @@ export default function ThemeChip() { | |||
<ThemeProvider theme={theme}> | |||
<Stack direction="row" spacing={2}> | |||
<Chip label="React" color="primary" onDelete={() => {}} /> | |||
<Chip label="Javascript" onDelete={() => {}} /> | |||
<Chip label="JavaScript" onDelete={() => {}} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7a47cc5
to
153b2d1
Compare
|
||
module.exports = { | ||
...baseline, | ||
baseline, // Exported so the other projects can use this configuration directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very familiar with these portions of the architecture, but it look good to me
Fix #33196 (comment) using vercel/next.js#37893 (comment)
Before: http://mui.com/
After: https://deploy-preview-34037--material-ui.netlify.app/
I have also made a change so that MUI X and MUI Toolpad can do:
They should get this bug fix for free, not have to apply it again.