Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Hide the default API column if it's empty #36715

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Mar 31, 2023

Resolves #35938 (comment), it hides the default column in the API properties table if none of the properties have default value.

Previously:

image

https://mui.com/base/api/use-tab/#parameters

Now:

image

https://deploy-preview-36715--material-ui.netlify.app/base/api/use-tab/#parameters

@mnajdova mnajdova added docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature labels Mar 31, 2023
@mui-bot
Copy link

mui-bot commented Mar 31, 2023

Netlify deploy preview

https://deploy-preview-36715--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 90b21ca

@mnajdova mnajdova marked this pull request as ready for review March 31, 2023 10:20
@mnajdova mnajdova merged commit ce1c1c3 into mui:master Mar 31, 2023
@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Mar 31, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 31, 2023

I think that before it was clear that there was no default value, with the new display, developers might wonder, what's the default? It's not displayed, Is it because it's "unknown" or is it "no default"? It might be more of a matter of: how can we have a denser API display, what Danilo was working on.

In any case, we can improve the first screenshot 😁: #36725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants