[Input][base] Fix calling slotProps event handlers #37463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-37463--material-ui.netlify.app/ Bundle size report |
sai6855
commented
Jun 1, 2023
| getSlotProps: (otherHandlers: EventHandlers) => { | ||
| return getInputProps({ | ||
| ...otherHandlers, | ||
| ...propsToForward, |
There was a problem hiding this comment.
otherHandlers will have eventHandlers passed in slotProps where as propsToForward will have eventHandlers passed to Input component.
According to previous code, eventHandlers in propsToForward will always override eventHandlers passed in slotProps, this PR adds a small caveat to the functionality, where eventHandlers in propsToForward will only override if there is valid function available.
ZeeshanTamboli
added
component: card
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #37134
before: https://codesandbox.io/s/broken-cookies-k6px3x?file=/demo.tsx:1459-1539
after: https://codesandbox.io/s/elated-bessie-7k0dkm