Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix flickering on mount #7155

Merged
merged 4 commits into from Dec 14, 2022
Merged

[DataGrid] Fix flickering on mount #7155

merged 4 commits into from Dec 14, 2022

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Dec 9, 2022 •
edited

Fixes #6595

Before: https://codesandbox.io/s/laughing-hopper-0mv8ll
After: https://codesandbox.io/s/jolly-leakey-h8b3jq

TODO:

  • Check docs-data-grid-style/StylingRowsGrid.png visual regression in Argos

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! feature: Rendering layout Related to the data grid Rendering engine design: ux labels Dec 9, 2022
@mui-bot
Copy link

mui-bot commented Dec 9, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 524.9 1,008.1 575.9 750.78 186.577
Sort 100k rows ms 577.9 1,271.6 577.9 937.28 282.55
Select 100k rows ms 197.6 312 276.5 271.06 39.811
Deselect 100k rows ms 136.1 299.3 208.9 220.5 68.269

Generated by 🚫 dangerJS against 8ffb9a6

@cherniavskii cherniavskii mentioned this pull request Dec 9, 2022
Closed
2 tasks
cherniavskii
cherniavskii commented Dec 9, 2022
View reviewed changes
packages/grid/x-data-grid/src/tests/keyboard.DataGrid.test.tsx
fireEvent.keyDown(input, { key: 'b' });
expect(renderCell.callCount).to.equal(4);
expect(renderCell.callCount).to.equal(6);
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand why the number of rerenders has changed 🙃

@cherniavskii cherniavskii marked this pull request as ready for review December 9, 2022 19:38
@cherniavskii cherniavskii merged commit 71827a5 into mui:master Dec 14, 2022
@cherniavskii cherniavskii deleted the fix-grid-flickering branch December 14, 2022 22:47
cherniavskii added a commit to cherniavskii/mui-x that referenced this pull request Dec 14, 2022
@cherniavskii
[DataGrid] Fix flickering on mount (mui#7155)
28e6a29
@cherniavskii cherniavskii mentioned this pull request Dec 14, 2022
Merged
cherniavskii added a commit to cherniavskii/mui-x that referenced this pull request Dec 15, 2022
@cherniavskii
[DataGrid] Fix flickering on mount (mui#7155)
403e99b
@cherniavskii cherniavskii mentioned this pull request Jan 17, 2023
Closed
2 tasks
@cherniavskii cherniavskii mentioned this pull request Feb 2, 2023
Closed
2 tasks
@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ux labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer feature: Rendering layout Related to the data grid Rendering engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Blank header and rows while mounting
4 participants
@cherniavskii @mui-bot @m4theushw @oliviertassinari