Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): add tests for ESLint 7 #224

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

MichaelDeBoey
Copy link

@MichaelDeBoey MichaelDeBoey commented May 8, 2020

package.json Outdated Show resolved Hide resolved
@weyert
Copy link

weyert commented Jun 22, 2020

Any plans to progress this feature/pull request?

@MichaelDeBoey
Copy link
Author

@weyert We still have to wait for mysticatea/eslint-utils#7 before we can start going forward with this one 🙂

@MichaelDeBoey
Copy link
Author

Since all tests are green for ESLint 7.x, I think we can merge this one without mysticatea/eslint-utils#7 being merged 🙂

@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review September 20, 2020 13:28
@pragmaticivan
Copy link

Howdy! any plans for merging this PR? I see it was ready to be merged 22 days ago

@MichaelDeBoey
Copy link
Author

@mysticatea All tests are green (locally), so I think we can merge this one 🙂

CC/ @sosukesuzuki @ota-meshi

@voxpelli
Copy link

Would it be possible to drop this down from a daunting 42 file change to something more narrowed and easier to review?

Looks like most of the diff is to sort object definitions by key and to eg. restructure the way that the CI setup is done? (Moving from an exclude to an include)

To really make reviewing and merging simpler, keeping the diff to a minimal is good 👍

@MichaelDeBoey
Copy link
Author

@voxpelli Most of the changes are due to updating @mysticatea/eslint-plugin.

Would it help if I created separate commits in order to understand a bit better what's happening?

@voxpelli
Copy link

The smaller chunks the easier to review and to understand the scope, so yes, one PR per such scope would be nice 👍

@MichaelDeBoey
Copy link
Author

MichaelDeBoey commented Nov 30, 2021

@voxpelli As I said before: doing everything in separate PRs won't be possible, as of the breaking changes

But I can create separate commits if that makes it easier for you

@MichaelDeBoey
Copy link
Author

@voxpelli I've merged #305, #306, #307, #308 & #309 and added one last commit to support ESLint v7.x

@MichaelDeBoey MichaelDeBoey marked this pull request as draft November 30, 2021 18:27
@MichaelDeBoey MichaelDeBoey changed the title feat: support ESLint 7.x chore(CI): add tests for ESLint 7 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 7.x
5 participants