New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ESLint 8.x #903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes causes unnecessarily big diffs, would be nice to avoid them 馃檪
a9ae1de should fix the failing run, so this should be rebased 馃檪 |
OK, our major is out: https://github.com/jest-community/eslint-plugin-jest/releases/tag/v25.0.0 My assumption is that landing this is a semver minor when (if not, numbers are cheap) |
6787dcb
to
554c000
Compare
dae2f55
to
db36086
Compare
3a7607a
to
be5bb93
Compare
fbd2cfb
to
9a46527
Compare
@SimenB Tests are failing but I can't figure out why, can you point me into the right direction so we can merge this one asap? |
@MichaelDeBoey the error about The error about |
9a46527
to
747d36e
Compare
747d36e
to
9454201
Compare
@G-Rath The prettier errors seem fixed now, but seems like we missed something |
@MichaelDeBoey looks like The Since I probably won't be able to look into this properly until the weekend, and because I think it might be the answer, if you want to look into adjusting our tests to skip running |
Note that config workaround is not needed with 8.0.1 https://github.com/eslint/eslint/releases/tag/v8.0.1 |
@@ -28,12 +30,18 @@ module.exports = { | |||
es6: true, | |||
}, | |||
rules: { | |||
// eslint-plugin-prettier removed ESLint v6 support | |||
...(semver.gte(version, '7.28.0') ? {} : { 'prettier/prettier': 'off' }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just keep using eslint-plugin-prettier@3
, no reason to upgrade it
@@ -60,6 +60,9 @@ | |||
"projects": [ | |||
{ | |||
"displayName": "test", | |||
"moduleNameMapper": { | |||
"@eslint/eslintrc/universal": "@eslint/eslintrc/dist/eslintrc-universal.cjs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@eslint/eslintrc/universal": "@eslint/eslintrc/dist/eslintrc-universal.cjs" | |
"eslint/use-at-your-own-risk": "eslint/lib/unsupported-api.js" |
This is whats giving unbound-method
trouble
(you can replace the existing map since we'll update to v8.0.1)
I just landed the other PR as this one has a bunch of changes we don't need. Thanks for your help here @MichaelDeBoey! |
馃帀 This issue has been resolved in version 25.1.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
ESLint v8.0.0 is released 馃帀
Dependencies should be compatible with ESLint 8 too before we can merge this one:
@typescript-eslint/experimental-utils
(Support for ESLint v8聽typescript-eslint/typescript-eslint#3738)meta.docs.category
from rules聽typescript-eslint/typescript-eslint#3800PrivateIdentifier
聽typescript-eslint/typescript-eslint#3808v5.0.0
devDependency compatibility with ESLint 8:
@typescript-eslint/eslint-plugin
(Support for ESLint v8聽typescript-eslint/typescript-eslint#3738)meta.docs.category
from rules聽typescript-eslint/typescript-eslint#3800PrivateIdentifier
聽typescript-eslint/typescript-eslint#3808v5.0.0
@typescript-eslint/parser
(Support for ESLint v8聽typescript-eslint/typescript-eslint#3738)meta.docs.category
from rules聽typescript-eslint/typescript-eslint#3800PrivateIdentifier
聽typescript-eslint/typescript-eslint#3808v5.0.0
eslint-plugin-eslint-comments
(Support ESLint 8.x聽mysticatea/eslint-plugin-eslint-comments#62)eslint-plugin-eslint-config
(Support ESLint 8.x聽G-Rath/eslint-plugin-eslint-config#8)eslint-plugin-eslint-plugin
(Support ESLint 8.x聽eslint-community/eslint-plugin-eslint-plugin#175)meta.hasSuggestions
property tometa-property-ordering
rule聽eslint-community/eslint-plugin-eslint-plugin#119v4.0.0-0
v4.0.0
eslint-plugin-import
(Support ESLint 8.x聽import-js/eslint-plugin-import#2211)v2.25.0
eslint-plugin-node
(Support ESLint 8.x聽mysticatea/eslint-plugin-node#294)eslint-plugin-prettier
(Support ESLint 8.x聽prettier/eslint-plugin-prettier#427)ReleaseSupersedes #882
Closes #881