Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support ESLint 7.x #7

Merged
merged 1 commit into from May 14, 2021
Merged

feat: Support ESLint 7.x #7

merged 1 commit into from May 14, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented May 16, 2020 •
edited

ESLint v7.0.0 is released 馃帀

(dev)Dependencies should be compatible with ESLint 7 too before we can merge this one:

BREAKING CHANGE: Requires Node@>=10.x

Closes #6

@MichaelDeBoey MichaelDeBoey mentioned this pull request May 16, 2020
Draft
9 tasks
@MichaelDeBoey MichaelDeBoey force-pushed the eslint-7 branch 11 times, most recently from 12f6411 to f1f2ba5 Compare May 16, 2020 17:21
@MichaelDeBoey MichaelDeBoey marked this pull request as draft June 11, 2020 09:53
@MichaelDeBoey MichaelDeBoey force-pushed the eslint-7 branch 6 times, most recently from 66dbccd to 184f159 Compare June 11, 2020 10:15
@MichaelDeBoey
Copy link
Contributor Author

@mysticatea I'm not seeing what's going wrong here, so any help getting this landed would be awesome!

@mysticatea
Copy link
Owner

You cannot use bash scripts on Windows.

@MichaelDeBoey
Copy link
Contributor Author

@mysticatea Any idea how I could resolve this?

@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 23, 2020
Open
@MichaelDeBoey MichaelDeBoey force-pushed the eslint-7 branch 2 times, most recently from 98f48c7 to 6fac4cb Compare June 23, 2020 23:54
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 24, 2020
Closed
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review June 30, 2020 17:32
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Jun 30, 2020 •
edited

@mysticatea I think this one's ready to be merged.

Just like eslint-plugin-es, I don't think we have to wait for @mysticatea/eslint-plugin, since that is creating a circular dependency.

This was referenced Jun 30, 2020
Draft
Merged
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jul 9, 2020
Merged
16 tasks
@iansu
Copy link

iansu commented Jul 24, 2020

@mysticatea This is the last thing blocking the release of Create React App v4 so if there's anything we can do to help get this merged and released please let me know.

@MichaelDeBoey
Copy link
Contributor Author

@iansu It just needs to be merged.
Afterwards I can merge dependent PRs too as they should be ready to merge as well.

@SimenB
Copy link

SimenB commented Jul 27, 2020

Why is this a blocker for anything? It adds a peer dep where there was none, and bumps a dependency which is within semver range. The rest of the changes seems internal to me

@MichaelDeBoey
Copy link
Contributor Author

Ping @mysticatea

This one can be merged 馃檪

@MichaelDeBoey MichaelDeBoey force-pushed the eslint-7 branch 2 times, most recently from 1227e61 to 162afdb Compare August 24, 2020 00:48
@MichaelDeBoey
Copy link
Contributor Author

@mysticatea Friendly reminder that this one can be merged 馃檪

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Sep 15, 2020 •
edited

@mysticatea Could you please merge this PR?
A lot of other PRs are waiting for this one in order to get ESLint 7 support, which will eventually lead to eslint-plugin-testing-library & eslint-config-react-app be fully ESLint 7 compatible for testing files too

@chrisbobbe chrisbobbe mentioned this pull request Sep 18, 2020
Closed
@MichaelDeBoey MichaelDeBoey mentioned this pull request Sep 19, 2020
Closed
@pragmaticivan
Copy link

Hi @mdjermanovic could we have this PR merged? Thanks!

@brettz9
Copy link

brettz9 commented Feb 17, 2021

Bueller? ;-)

@MichaelDeBoey
feat: Support ESLint 7.x
c5c71dd 
BREAKING CHANGE: Requires Node@>=10.x
@mysticatea mysticatea merged commit 9a5c4fb into mysticatea:master May 14, 2021
@mysticatea
Copy link
Owner

I apologize for my lack of response. For a long time, I had been away from OSS activities for personal reasons.

This package has been used in ESLint core, so I thought we didn't need to do anything in order to support ESLint 7. I merged this PR as upgrading dependencies and dropping old Node.js versions.

@MichaelDeBoey
Copy link
Contributor Author

Thanks for merging this one @mysticatea! 馃憡

@MichaelDeBoey MichaelDeBoey deleted the eslint-7 branch May 14, 2021 09:55
fisker pushed a commit to fisker/eslint-utils that referenced this pull request Nov 28, 2022
@MichaelDeBoey
chore: create dependabot.yml (mysticatea#7)
1ec4c4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjermanovic mdjermanovic mdjermanovic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ESLint 7.x
7 participants
@MichaelDeBoey @mysticatea @iansu @SimenB @pragmaticivan @brettz9 @mdjermanovic