Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Update FE telemetry for RBAC #9343

Merged
merged 6 commits into from May 9, 2024
Merged

fix(editor): Update FE telemetry for RBAC #9343

merged 6 commits into from May 9, 2024

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 8, 2024
@cstuncsik cstuncsik force-pushed the pay-1374-add-telemetry-for-rbac branch from 3b73c4b to 880d300 Compare May 9, 2024 04:40
@cstuncsik cstuncsik marked this pull request as ready for review May 9, 2024 07:32
krynble
krynble reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although there seems to be a broken test

@cstuncsik
Copy link
Contributor Author

Fixed and extended the unit test

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented May 9, 2024

10 failed tests on run #4914 ↗︎

10 219 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: 502ce6837c
Status: Failed Duration: 05:46 💡
Started: May 9, 2024 12:01 PM Ended: May 9, 2024 12:07 PM
Failed  17-sharing.cy.ts • 8 failed tests

View Output Video

Test Artifacts
Sharing > should create C1, W1, W2, share W1 with U3, as U2 Test Replay Screenshots Video
Sharing > should create C2, share C2 with U1 and U2, as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U2 Test Replay Screenshots Video
Sharing > should not have access to W2, as U3 Test Replay Screenshots Video
Sharing > should have access to W1, W2, as U1 Test Replay Screenshots Video
Sharing > should automatically test C2 when opened by U2 sharee Test Replay Screenshots Video
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video
Failed  7-workflow-actions.cy.ts • 1 failed test

View Output Video

Test Artifacts
Workflow Actions > duplicate workflow > should duplicate unsaved workflow Test Replay Screenshots Video
Failed  39-projects.cy.ts • 1 failed test

View Output Video

Test Artifacts
Projects > should handle workflows and credentials Test Replay Screenshots Video
Failed  9-expression-editor-modal.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  14-mapping.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 37 specs in Cypress Cloud.

Review all test suite changes for PR #9343 ↗︎

@krynble krynble merged commit 4c2ef5f into feature/rbac May 9, 2024
25 of 30 checks passed
@krynble krynble deleted the pay-1374-add-telemetry-for-rbac branch May 9, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cstuncsik @krynble