fix(editor): Update FE telemetry for RBAC

packages/editor-ui/src/components/DuplicateWorkflowDialog.vue

@@ -171,8 +171,7 @@ export default defineComponent({
 					this.$telemetry.track('User duplicated workflow', {
 						old_workflow_id: currentWorkflowId,
 						workflow_id: this.data.id,
-						// Hardcoding a value as this needs to be updated in the future anyways
-						sharing_role: 'unknown',
+						sharing_role: this.workflowHelpers.getWorkflowProjectRole(this.data.id),
 					});
 				}
 			} catch (error) {

packages/editor-ui/src/components/Telemetry.vue

@@ -9,6 +9,7 @@ import { useRootStore } from '@/stores/n8nRoot.store';
 import { useSettingsStore } from '@/stores/settings.store';
 import { useUsersStore } from '@/stores/users.store';
 import type { ITelemetrySettings } from 'n8n-workflow';
+import { useProjectsStore } from '@/features/projects/projects.store';
 
 export default defineComponent({
 	name: 'Telemetry',
@@ -18,7 +19,7 @@ export default defineComponent({
 		};
 	},
 	computed: {
-		...mapStores(useRootStore, useSettingsStore, useUsersStore),
+		...mapStores(useRootStore, useSettingsStore, useUsersStore, useProjectsStore),
 		currentUserId(): string {
 			return this.usersStore.currentUserId || '';
 		},
@@ -62,6 +63,7 @@ export default defineComponent({
 			this.$telemetry.init(this.telemetry, {
 				instanceId: this.rootStore.instanceId,
 				userId: this.currentUserId,
+				projectId: this.projectsStore.personalProject?.id,
 				versionCli: this.rootStore.versionCli,
 			});
 

packages/editor-ui/src/components/WorkflowShareModal.ee.vue

@@ -40,6 +40,8 @@
 							:readonly="!workflowPermissions.share"
 							:static="isHomeTeamProject"
 							:placeholder="$locale.baseText('workflows.shareModal.select.placeholder')"
+							@project-added="onProjectAdded"
+							@project-removed="onProjectRemoved"
 						/>
 						<n8n-info-tip v-if="isHomeTeamProject" :bold="false" class="mt-s">
 							<i18n-t keypath="workflows.shareModal.info.members" tag="span">
@@ -143,6 +145,7 @@ import { useUIStore } from '@/stores/ui.store';
 import { useUsersStore } from '@/stores/users.store';
 import { useWorkflowsStore } from '@/stores/workflows.store';
 import { useWorkflowsEEStore } from '@/stores/workflows.ee.store';
+import type { ITelemetryTrackProperties } from 'n8n-workflow';
 import type { BaseTextKey } from '@/plugins/i18n';
 import { isNavigationFailure } from 'vue-router';
 import ProjectSharing from '@/features/projects/components/ProjectSharing.vue';
@@ -262,6 +265,18 @@ export default defineComponent({
 		await this.initialize();
 	},
 	methods: {
+		onProjectAdded(project: ProjectSharingData) {
+			this.trackTelemetry('User selected sharee to add', {
+				project_id_sharer: this.workflow.homeProject?.id,
+				project_id_sharee: project.id,
+			});
+		},
+		onProjectRemoved(project: ProjectSharingData) {
+			this.trackTelemetry('User selected sharee to remove', {
+				project_id_sharer: this.workflow.homeProject?.id,
+				project_id_sharee: project.id,
+			});
+		},
 		async onSave() {
 			if (this.loading) {
 				return;
@@ -331,6 +346,12 @@ export default defineComponent({
 			});
 			this.modalBus.emit('close');
 		},
+		trackTelemetry(eventName: string, data: ITelemetryTrackProperties) {
+			this.$telemetry.track(eventName, {
+				workflow_id: this.workflow.id,
+				...data,
+			});
+		},
 		goToUpgrade() {
 			void this.uiStore.goToUpgrade('workflow_sharing', 'upgrade-workflow-sharing');
 		},

packages/editor-ui/src/composables/useWorkflowHelpers.ts

@@ -940,7 +940,7 @@ export function useWorkflowHelpers(options: { router: ReturnType<typeof useRoute
 			if (error.errorCode === 100) {
 				telemetry.track('User attempted to save locked workflow', {
 					workflowId: currentWorkflow,
-					sharing_role: workflowPermissions.value.isOwner ? 'owner' : 'sharee',
+					sharing_role: getWorkflowProjectRole(currentWorkflow),
 				});
 
 				const url = router.resolve({
@@ -1182,6 +1182,22 @@ export function useWorkflowHelpers(options: { router: ReturnType<typeof useRoute
 		});
 	}
 
+	function getWorkflowProjectRole(workflowId: string): 'owner' | 'sharee' | 'member' {
+		const workflow = workflowsStore.workflowsById[workflowId];
+
+		if (workflow.homeProject?.id === projectsStore.personalProject?.id) {
+			return 'owner';
+		} else if (
+			workflow.sharedWithProjects?.some(
+				(project) => project.id === projectsStore.personalProject?.id,
+			)
+		) {
+			return 'sharee';
+		} else {
+			return 'member';
+		}
+	}
+
 	return {
 		resolveParameter,
 		resolveRequiredParameters,
@@ -1207,5 +1223,6 @@ export function useWorkflowHelpers(options: { router: ReturnType<typeof useRoute
 		dataHasChanged,
 		removeForeignCredentialsFromWorkflow,
 		workflowPermissions,
+		getWorkflowProjectRole,
 	};
 }

packages/editor-ui/src/features/projects/components/ProjectSharing.vue

@@ -22,6 +22,10 @@ const props = defineProps<Props>();
 const model = defineModel<(ProjectSharingData | null) | ProjectSharingData[]>({
 	required: true,
 });
+const emit = defineEmits<{
+	(event: 'projectAdded', value: ProjectSharingData): void;
+	(event: 'projectRemoved', value: ProjectSharingData): void;
+}>();
 
 const selectedProject = ref(Array.isArray(model.value) ? '' : model.value?.id ?? '');
 const filter = ref('');
@@ -61,6 +65,7 @@ const onProjectSelected = (projectId: string) => {
 	} else {
 		model.value = project;
 	}
+	emit('projectAdded', project);
 };
 
 const onRoleAction = (project: ProjectSharingData, role: string) => {
@@ -75,6 +80,7 @@ const onRoleAction = (project: ProjectSharingData, role: string) => {
 
 	if (role === 'remove') {
 		model.value = model.value.filter((p) => p.id !== project.id);
+		emit('projectRemoved', project);
 	}
 };
 

packages/editor-ui/src/plugins/__tests__/telemetry.test.ts

@@ -66,6 +66,30 @@ describe('telemetry', () => {
 			});
 		});
 
+		it('Rudderstack identify method should be called when proving userId and versionCli and projectId', () => {
+			const identifyFunction = vi.spyOn(window.rudderanalytics, 'identify');
+
+			const userId = '1';
+			const instanceId = '1';
+			const versionCli = '1';
+			const projectId = '1';
+
+			settingsStore.setSettings(
+				merge({}, SETTINGS_STORE_DEFAULT_STATE.settings, {
+					deployment: {
+						type: '',
+					},
+				}),
+			);
+
+			telemetry.identify(userId, instanceId, versionCli, projectId);
+			expect(identifyFunction).toHaveBeenCalledTimes(1);
+			expect(identifyFunction).toHaveBeenCalledWith(`${instanceId}#${userId}#${projectId}`, {
+				instance_id: instanceId,
+				version_cli: versionCli,
+			});
+		});
+
 		it('Rudderstack identify method should be called when proving userId and deployment type is cloud ', () => {
 			const identifyFunction = vi.spyOn(window.rudderanalytics, 'identify');
 

packages/editor-ui/src/plugins/telemetry/index.ts

@@ -45,10 +45,12 @@ export class Telemetry {
 		{
 			instanceId,
 			userId,
+			projectId,
 			versionCli,
 		}: {
 			instanceId: string;
 			userId?: string;
+			projectId?: string;
 			versionCli: string;
 		},
 	) {
@@ -73,13 +75,13 @@ export class Telemetry {
 		});
 		useTelemetryStore().init(this);
 
-		this.identify(instanceId, userId, versionCli);
+		this.identify(instanceId, userId, versionCli, projectId);
 
 		this.flushPageEvents();
 		this.track('Session started', { session_id: rootStore.pushRef });
 	}
 
-	identify(instanceId: string, userId?: string, versionCli?: string) {
+	identify(instanceId: string, userId?: string, versionCli?: string, projectId?: string) {
 		const settingsStore = useSettingsStore();
 		const traits: { instance_id: string; version_cli?: string; user_cloud_id?: string } = {
 			instance_id: instanceId,
@@ -90,7 +92,10 @@ export class Telemetry {
 			traits.user_cloud_id = settingsStore.settings?.n8nMetadata?.userId ?? '';
 		}
 		if (userId) {
-			this.rudderStack.identify(`${instanceId}#${userId}`, traits);
+			this.rudderStack.identify(
+				`${instanceId}#${userId}${projectId ? '#' + projectId : ''}`,
+				traits,
+			);
 		} else {
 			this.rudderStack.reset();
 		}