Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic: x86_64: refactor patch code #1745

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

dynamic: x86_64: refactor patch code #1745

wants to merge 4 commits into from

Conversation

clementguidi
Copy link
Contributor

@clementguidi clementguidi commented Jul 7, 2023 •
edited

This is the fifth PR in a series of patches intended to bring runtime dynamic tracing on x86_64 to uftrace.

  1. dynamic: Refactor logic to perform multiple updates聽#1702
  2. dynamic: Refactor patch pattern logic聽#1703
  3. configure: Check for membarrier support聽#1704
  4. utils: Add helpers for runtime dynamic patching聽#1705
  5. dynamic: x86_64: refactor patch code聽#1745 馃爤
  6. dynamic: x86_64: Support runtime dynamic patching聽#1746
  7. dynamic: x86_64: Optimize runtime dynamic patching聽#1747
  8. dynamic: x86 64: Support runtime dynamic unpatching聽#1748
  9. agent: Trigger runtime dynamic instrumentation聽#1749
  10. dynamic: x86_64: Fall back to original patching strategy when target is not running聽#1750
  11. dynamic: Display enhanced dynamic stats聽#1751

We refactor code for clarity and prepare patch_code to be used at runtime.

Related: #1698

clementguidi and others added 4 commits July 6, 2023 11:52
@clementguidi
dynamic: x86_64: Skip already patched functions
58b9110 
Skip the functions where uftrace already injected a call to a
trampoline.

Signed-off-by: Cl茅ment Guidi <cguidi@ciena.com>
@clementguidi
dynamic: x86_64: Refactor 'get_target_address'
6b6055b 
Refactor for more clarity.

Signed-off-by: Cl茅ment Guidi <cguidi@ciena.com>
@clementguidi @gpollo
dynamic: x86_64: Refactor 'patch_code'
7a283c4 
Refactor 'patch_code' so it can later be used at runtime.

Co-authored-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Cl茅ment Guidi <cguidi@ciena.com>
@clementguidi
dynamic: x86_64: Factor out 'check_endbr64'
1684329 
Check if instruction at a given address is ENDBR64.

Signed-off-by: Cl茅ment Guidi <cguidi@ciena.com>
This was referenced Jul 7, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
namhyung
namhyung reviewed Jul 10, 2023
View reviewed changes
arch/x86_64/mcount-dynamic.c
/*
* We fill the remaining part of the patching region with nops.
*
* 0x0: int3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you update the first byte?

@bernhardkaindl bernhardkaindl mentioned this pull request Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namhyung namhyung namhyung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clementguidi @namhyung