New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADDED] Listing KeyValue store and KeyValue store names #1088
Conversation
func (js *js) KeyValueStoreNames() <-chan string { | ||
ch := make(chan string) | ||
l := &streamLister{js: js} | ||
l.js.opts.streamListSubject = fmt.Sprintf(kvSubjectsTmpl, "*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if this subject will work with the JS Prefix? Or whether it needs something like js.apiSubj()
to make it so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the filter subject for STREAM.LIST
api and points to $KV.%s.>
. AFAIK, CreateKeyValue()
creates a stream with interest in this subject (%s
is the name), so there is no need for $JS
prefix. Or do I misunderstand it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh right, ok then there is no need for the prefix there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #1075