js: Add note on ephemeral consumers and Subscribe #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
approved these changes
Jul 28, 2021
js.go
Outdated
| @@ -952,6 +952,10 @@ func (opt subOptFn) configureSubscribe(opts *subOpts) error { | |||
| } | |||
|
|
|||
| // Subscribe will create a subscription to the appropriate stream and consumer. | |||
| // By default, it will automatically create an JetStream consumer in the server in case | |||
There was a problem hiding this comment.
an->a in an JetStream consumer.
| // By default, it will automatically create an JetStream consumer in the server in case | ||
| // one cannot be found. Unless the `Durable` option is passed, the consumer will be | ||
| // ephemeral and automatically cleaned up by the server if the client that created | ||
| // the consumer goes away. |
There was a problem hiding this comment.
Correct, but then the library is still trying to delete on Unsusbcribe(), so we will have to address that.
wallyqs
commented
Jul 28, 2021
|
Closing in favor of PR #794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some notes on ephemeral consumers being the default.