Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js: Add note on ephemeral consumers and Subscribe #782

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion js.go
Expand Up @@ -952,6 +952,10 @@ func (opt subOptFn) configureSubscribe(opts *subOpts) error {
}

// Subscribe will create a subscription to the appropriate stream and consumer.
// By default, it will automatically create an JetStream consumer in the server in case
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an->a in an JetStream consumer.

wallyqs marked this conversation as resolved.
Show resolved Hide resolved
// one cannot be found. Unless the `Durable` option is passed, the consumer will be
// ephemeral and automatically cleaned up by the server if the client that created
// the consumer goes away.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, but then the library is still trying to delete on Unsusbcribe(), so we will have to address that.

func (js *js) Subscribe(subj string, cb MsgHandler, opts ...SubOpt) (*Subscription, error) {
if cb == nil {
return nil, ErrBadSubscription
Expand Down Expand Up @@ -989,7 +993,8 @@ func (js *js) ChanQueueSubscribe(subj, queue string, ch chan *Msg, opts ...SubOp
return js.subscribe(subj, queue, nil, ch, false, opts)
}

// PullSubscribe creates a pull subscriber.
// PullSubscribe creates a pull subscriber. In case a consumer with the durable name
// is not present, it will attempt to create one with the default configuration.
func (js *js) PullSubscribe(subj, durable string, opts ...SubOpt) (*Subscription, error) {
return js.subscribe(subj, _EMPTY_, nil, nil, false, append(opts, Durable(durable)))
}
Expand Down