New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
js: Add note on ephemeral consumers and Subscribe #782
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -952,6 +952,10 @@ func (opt subOptFn) configureSubscribe(opts *subOpts) error { | |
} | ||
|
||
// Subscribe will create a subscription to the appropriate stream and consumer. | ||
// By default, it will automatically create an JetStream consumer in the server in case | ||
wallyqs marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// one cannot be found. Unless the `Durable` option is passed, the consumer will be | ||
// ephemeral and automatically cleaned up by the server if the client that created | ||
// the consumer goes away. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct, but then the library is still trying to delete on Unsusbcribe(), so we will have to address that. |
||
func (js *js) Subscribe(subj string, cb MsgHandler, opts ...SubOpt) (*Subscription, error) { | ||
if cb == nil { | ||
return nil, ErrBadSubscription | ||
|
@@ -989,7 +993,8 @@ func (js *js) ChanQueueSubscribe(subj, queue string, ch chan *Msg, opts ...SubOp | |
return js.subscribe(subj, queue, nil, ch, false, opts) | ||
} | ||
|
||
// PullSubscribe creates a pull subscriber. | ||
// PullSubscribe creates a pull subscriber. In case a consumer with the durable name | ||
// is not present, it will attempt to create one with the default configuration. | ||
func (js *js) PullSubscribe(subj, durable string, opts ...SubOpt) (*Subscription, error) { | ||
return js.subscribe(subj, _EMPTY_, nil, nil, false, append(opts, Durable(durable))) | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an
->a
inan JetStream consumer
.