This repository has been archived by the owner on Nov 12, 2021. It is now read-only.
Cross-platform Picker component with real i18n in tests #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add @react-native-community/picker to modules Jest must transpile
Previously it seemed to be included indirectly through subcomponents, which risks timing issues
andreaforni
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Good job @AlanSl, looks good to me. I've just left a non-blocking comment about test's name convention.
| }; | ||
|
|
||
| describe('Picker Sheet', () => { | ||
| it('value change calls onValueChange function', () => { |
There was a problem hiding this comment.
If I use the it() function to define a test, I usually change the test's name/description to include it as the subject of the sentence, to express the intention of the test (like in the e2e test: it('changes the app language')).
Another option, would be leave the name/description as is, and use test() instead.
There was a problem hiding this comment.
Good call, consistency is good, I'll change it
AlanSl
added a commit
that referenced
this pull request
Jul 10, 2020
* Install @react-native-community/picker, run expo update
Also add @react-native-community/picker to modules Jest must transpile
* Split cross-platform picker and language-selector
* Use cross-platform picker in ListView
* Update tests to use real i18n and web picker
* Explicitly include i18n in app
Previously it seemed to be included indirectly through subcomponents, which risks timing issues
* Update e2e test, using same test ID as unit tests
* Add readme note on using i18n in tests
* Write test name as "It {does thing}" sentence
* Also write other test name as "It {does thing}"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pickerfor the officially-endorsed @react-native-community/picker which is supported in Expo SDK 38changeLanguagereally do change the language (using i18n'scimode, sotcontinues to return the stable key in tests rather than the more-changable translated text)PickerSheeta generic "did the function call" unit test and theLanguageSwitchera real test asserting that components withuseTranslationdo re-render on changes with a new languageTested on Web, simulated iOS and real Android. Fixed iOS view: