Skip to content
This repository has been archived by the owner on Nov 12, 2021. It is now read-only.

Cross-platform Picker component with real i18n in tests #44

Merged
merged 9 commits into from Jul 8, 2020
Merged

Cross-platform Picker component with real i18n in tests #44

merged 9 commits into from Jul 8, 2020

Commits on Jul 8, 2020

  1. Install @react-native-community/picker, run expo update 

    Also add @react-native-community/picker to modules Jest must transpile
    @AlanSl
    AlanSl committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    2cb337e View commit details
    Browse the repository at this point in the history

  2. Split cross-platform picker and language-selector

    @AlanSl
    AlanSl committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    4bed459 View commit details
    Browse the repository at this point in the history

  3. Use cross-platform picker in ListView

    @AlanSl
    AlanSl committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    1776f93 View commit details
    Browse the repository at this point in the history

  4. Update tests to use real i18n and web picker

    @AlanSl
    AlanSl committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    7cce3a9 View commit details
    Browse the repository at this point in the history

  5. Explicitly include i18n in app 

    Previously it seemed to be included indirectly through subcomponents, which risks timing issues
    @AlanSl
    AlanSl committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    7477716 View commit details
    Browse the repository at this point in the history

  6. Update e2e test, using same test ID as unit tests

    @AlanSl
    AlanSl committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    2200bcc View commit details
    Browse the repository at this point in the history

  7. Add readme note on using i18n in tests

    @AlanSl
    AlanSl committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    06e07fd View commit details
    Browse the repository at this point in the history

  8. Write test name as "It {does thing}" sentence

    @AlanSl
    AlanSl committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    139dd72 View commit details
    Browse the repository at this point in the history

  9. Also write other test name as "It {does thing}"

    @AlanSl
    AlanSl committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    32f6c23 View commit details
    Browse the repository at this point in the history