Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump electron from 16.2.8 to 18.3.7 #2525

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 10, 2022

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 10, 2022
@Keith-CY
Copy link
Collaborator

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 13, 2022

Looks like this PR is already up-to-date with develop! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@Keith-CY
Copy link
Collaborator

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/electron-18.3.7 branch from 16cac7a to 30d035d Compare November 13, 2022 09:45
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/electron-18.3.7 branch from 30d035d to 32abf79 Compare December 4, 2022 14:36
@Keith-CY
Copy link
Collaborator

Keith-CY commented Dec 6, 2022

The CI failed because dependabot is not allowed to build a package.

This update is major and should be fully tested before being merged into the dev branch @Cedar67

@Keith-CY Keith-CY requested a review from Cedar67 December 6, 2022 05:30
@Keith-CY
Copy link
Collaborator

Keith-CY commented Dec 6, 2022

@dependabot rebase

Bumps [electron](https://github.com/electron/electron) from 16.2.8 to 18.3.7.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v16.2.8...v18.3.7)

---
updated-dependencies:
- dependency-name: electron
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/electron-18.3.7 branch from 32abf79 to 01c1c51 Compare December 6, 2022 05:31
@Keith-CY
Copy link
Collaborator

Keith-CY commented Dec 6, 2022

Breaking changes from 16.2.8 to 18.3.7

  • desktopCapturer.getSources is now only available in the main process. #30720
  • Removed the old BrowserWindowProxy-based implementation of window.open. This also removes the nativeWindowOpen option from webPreferences. #29405

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 6, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/electron-18.3.7 branch December 6, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants