refactor(microservices): disable ping timer message in nats by flag #10798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Comment on lines
60
to
63
| if (status.type === 'pingTimer' && this.options.debug) { | ||
| this.logger.debug( | ||
| `NatsStatus: type: "${status.type}", data: "${data}".`, | ||
| ); |
There was a problem hiding this comment.
What about errors not of type pingTimer?
There was a problem hiding this comment.
True, I missed it. I will fix it. What do you think about switch case for everyone status type? I guess its will be more clear for understanding about logic in handleStatusUpdates.
Example:
switch (status.type) {
case 'error':
case 'disconnect':
this.logger.error(
`NatsError: type: "${status.type}", data: "${data}".`
);
break;
case 'pingTimer':
if (this.options.debug) {
this.logger.debug(
`NatsStatus: type: "${status.type}", data: "${data}".`
);
}
break;
default:
this.logger.log(
`NatsStatus: type: "${status.type}", data: "${data}".`
);
break;
}
Pull Request Test Coverage Report for Build ba2623a9-72df-472a-80de-48f52028c6d2
💛 - Coveralls |
bittlerr
approved these changes
Jan 5, 2023
|
@kamilmysliwiec what do you think of the solution @andreyddk provided? |
|
@kamilmysliwiec any news here? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The debug message of nats server is annoying and its cant be disabled.
DEBUG [Server] NatsStatus: type: "pingTimer", data: "1".Issue Number: 10783
What is the new behavior?
My propose it is extends the implementation existed flag debug of MicroserviceOptions for disable pingTimer message.
Does this PR introduce a breaking change?
Other information