Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): middleware runs once for matching route #9809

Merged
merged 3 commits into from Jun 12, 2023
Merged

feat(core): middleware runs once for matching route #9809

merged 3 commits into from Jun 12, 2023

Conversation

rychardvale
Copy link
Contributor

@rychardvale rychardvale commented Jun 20, 2022 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Currently, routes that has dynamic params can trigger a middleware multiple times for a single request if matches another static route inside the controller.

Issue Number: #1628

What is the new behavior?

Routes will only trigger the middleware for the exact path match.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Jun 20, 2022 •
edited

Pull Request Test Coverage Report for Build c179baca-5af3-4693-b615-af5c35fafab1

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build a1d27e3b-ce8d-4a6c-bebb-92a0cc67fc15: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@kamilmysliwiec kamilmysliwiec mentioned this pull request Jun 20, 2022
Closed
Tony133
Tony133 suggested changes Jun 26, 2022
View reviewed changes
Copy link
Contributor

@Tony133 Tony133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little convention/syntax fix while otherwise fine, but let's see what Kamil thinks.

packages/core/middleware/builder.ts Outdated Show resolved Hide resolved
@rychardvale @Tony133
fix: convention/code style.
b0837af 
Co-authored-by: Antonio T. as Tony <Tony133@users.noreply.github.com>
@MatthiasKunnen MatthiasKunnen mentioned this pull request May 17, 2023
Closed
5 tasks
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 10.0.0 June 12, 2023 07:46
@kamilmysliwiec kamilmysliwiec merged commit 8053f11 into nestjs:10.0.0 Jun 12, 2023
@kamilmysliwiec kamilmysliwiec mentioned this pull request Jun 12, 2023
Merged
12 tasks
@rychardvale rychardvale deleted the fix-middleware-multiple-runs branch June 15, 2023 13:58
@micalevisk micalevisk mentioned this pull request Jun 19, 2023
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tony133 Tony133 Tony133 approved these changes

@micalevisk micalevisk micalevisk approved these changes

@hebertcisco hebertcisco hebertcisco approved these changes

Assignees
No one assigned
Labels
scope: core type: enhancement 🐺
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rychardvale @coveralls @Tony133 @micalevisk @hebertcisco @kamilmysliwiec