This repository has been archived by the owner on May 22, 2024. It is now read-only.
feat: add generator as an option to config and save it in the manifest and remove isInternal #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khendrikse
added
the
type: feature
khendrikse
changed the title
⏱ Benchmark resultsComparing with cde6f11 largeDepsEsbuild: 2.1s⬇️ 20.51% decrease vs. cde6f11 Legend
largeDepsNft: 8.1s⬇️ 26.78% decrease vs. cde6f11 Legend
largeDepsZisi: 15.5s⬇️ 21.19% decrease vs. cde6f11 Legend
|
khendrikse
force-pushed
the
feat-350/add-generator-option-to-config-and-manifest
branch
2 times, most recently
from
8202346
to
1cf4fef
Compare
5 tasks
khendrikse
force-pushed
the
feat-350/add-generator-option-to-config-and-manifest
branch
from
1cf4fef
to
f8db3d1
Compare
danez
approved these changes
Feb 16, 2023
| - _Type_: `string` | ||
| - _Default value_: undefined | ||
|
|
||
| A field to use if the function has been autogenerated by a plugin or integration. A recommended format is `@netlify/fake-plugin@1.0.0`, where adding the version is highly appreciated. |
There was a problem hiding this comment.
I wonder about this scenario:
A user has a website with an integration at version 1.0.0. The user updates the integration to 1.0.1, and the following build will build the functions, but the functions are identical to the one previously, so we do not upload them. The version, in this case, will still be at 1.0.0 in the generator field probably, even though 1.0.1 is installed and deploys have happened with this version.
We should check if this is the case. Not a big issue, just something to keep in mind that the version in the generator field might not be equal the version that is installed.
There was a problem hiding this comment.
Good point, I'll start looking into this!
There was a problem hiding this comment.
I checked how this currently works for the (display) name. If I only update the configuration file, but the function itself is the same, I'm still getting the new name in the UI.
And I think it's because of the stage in which we update this information in mongodb. We always send the information. (implementation in bitballoon (pr 1, pr 2))
I think the stage happens before we actually upload the function 🤔 but I'm going to ask @biruwon to confirm.
khendrikse
deleted the
feat-350/add-generator-option-to-config-and-manifest
branch
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…t and remove isInternal (netlify/zip-it-and-ship-it#1341) * feat: add generator as an option to config and save it in the manifest * test: add test and remove internalSrcFolder usage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
In this PR we do the following:
isInternalandinternalSrcFolderconfiguration options.generatorconfiguration option.For more information about the why, feel free to check this issue: https://github.com/netlify/pod-compute/issues/350
For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
