fix: headers and actions empty variable init #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/actions-headers
branch
from
cfc3162
to
9c850ab
Compare
|
👍 Would you mind adding test case for this? |
Already covered :) |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
But than the test should have already failed before this? I take the liberty to push a commit with a test so can see what I meant |
susnux
approved these changes
Aug 11, 2023
Fair point! Let's also add for actions then, let me do it |
…s` reactivity Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
force-pushed
the
fix/actions-headers
branch
from
60a8c8d
to
23548bb
Compare
|
Done! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise if an app uses
getFileActionsorgetFileListHeadersBEFORE any other app registered one, the returned empty array will not point to the window reference and will not be reactive