Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from deprecated title prop #4052

Merged
merged 1 commit into from May 9, 2023
Merged

Migrate from deprecated title prop #4052

merged 1 commit into from May 9, 2023

Conversation

raimund-schluessler
Copy link
Contributor

Since master is 8.0.0 now, we can merge all breaking changes scheduled for the next major.

This PR removes the nameTitleFallback and makes the name prop required for NcActions*, NcAppNavigationItem and NcBreadcrumb*.

@raimund-schluessler
Migrate from deprecated title prop
25ce3d8 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added the 3. to review Waiting for reviews label May 7, 2023
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone May 7, 2023
skjnldsv
skjnldsv approved these changes May 7, 2023
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be any more awesome Raimund? 😍
🙇

@raimund-schluessler raimund-schluessler mentioned this pull request May 7, 2023
Closed
@skjnldsv skjnldsv merged commit 8d9ad47 into master May 9, 2023
16 checks passed
@skjnldsv skjnldsv deleted the fix/noid/name-title-deprecation branch May 9, 2023 06:11
@ShGKme
Copy link
Contributor

ShGKme commented May 9, 2023

Should we start to make breaking changes list or migration guide?

@nickvergessen
Copy link
Contributor

A migration guide similar to the OCP changes sounds like a wunderful idea!

@raimund-schluessler raimund-schluessler added the breaking PR that requires a new major version label May 11, 2023
@nickvergessen nickvergessen mentioned this pull request May 12, 2023
Closed
@juliushaertl juliushaertl mentioned this pull request Jun 29, 2023
Merged
1 task
max-nextcloud added a commit to nextcloud/collectives that referenced this pull request Nov 9, 2023
@max-nextcloud
fix(ui): title prop is deprecated since @nextcloud/vue 7
cce1a58 
See nextcloud-libraries/nextcloud-vue#4052.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud mentioned this pull request Nov 9, 2023
Merged
2 tasks
mejo- pushed a commit to nextcloud/collectives that referenced this pull request Nov 9, 2023
@max-nextcloud @mejo-
fix(ui): title prop is deprecated since @nextcloud/vue 7
214acd4 
See nextcloud-libraries/nextcloud-vue#4052.

Signed-off-by: Max <max@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews breaking PR that requires a new major version
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@raimund-schluessler @ShGKme @nickvergessen @skjnldsv @Pytal