Files : Left panel dropdown improvement for NC 26

[Jerome-Herbinet]

• Resolves: #38155

(from @Clementine46)

/!\ Testing is welcome in order to make sure it's not doing side effects elsewhere in the UI.

Before :

before.webm

After :

after.webm

[Jerome-Herbinet]

Also see the other PR for Nextcloud 25 nextcloud/server#38217

[nimishavijay]

Super nice! I would only suggest that the hover effect doesn't need to use the primary color as we don't use that pattern anywhere else yet, the hover feedback can just be the change in the background color :) other than that it looks great!

[Jerome-Herbinet]

Super nice! I would only suggest that the hover effect doesn't need to use the primary color as we don't use that pattern anywhere else yet, the hover feedback can just be the change in the background color :) other than that it looks great!

Thanks for the comment @nimishavijay ; can you just give me more details about what hover effect you are talking about. I'm not sure to understand ... or can you join and illustrated screenshot ? (there are 2 hover effects that I didn't change : the one under the dropdown arrow and the one under the whole button).

[nimishavijay]

I meant the hover effect under the dropdown button icon, on hover the icon changes to the primary color.

I just checked the other apps, and you are right, nothing has been changed by you. However, it's not intended in the first place. So I suggest on hover we could just have the background color changing, and the color of the icon can remain the same (--color-main-text). What do you think? :)

[Jerome-Herbinet]

I meant the hover effect under the dropdown button icon, on hover the icon changes to the primary color.

I just checked the other apps, and you are right, nothing has been changed by you. However, it's not intended in the first place. So I suggest on hover we could just have the background color changing, and the color of the icon can remain the same (--color-main-text). What do you think? :)

OK understood @nimishavijay :-) It's done.

[nimishavijay]

If the hover effect has been changed, then it is good to go! nice work! :)

[skjnldsv]

/backport to stable7

[GretaD]

this pr breaks mail, and most probably other apps that have an actionmenu on side bar

[Jerome-Herbinet]

this pr breaks mail, and most probably other apps that have an actionmenu on side bar

@GretaD,
Thanks for your feedback.
IMO it seems complicated to separate behaviour in nextcloud-vue to apply styles only in "Files" context (obviously, I don't find there any specific class or id to target, relative to Files context).
Instead, what do you think about trying to override CSS styles in apps.scss (core) ?
Any other suggestion ?

@nimishavijay @jancborchardt @juliushaertl

[szaimen]

I think this needs to be handled by this component. If both features are used at the same time, it should not coolide but instead be shown next to each other.

[ChristophWurst]

Apps are reaching RC state for Nextcloud 27 today. Can this be fixed quickly or should we revert and redo cleanly?

[Jerome-Herbinet]

I think things look more delicate and complex than I thought before starting to work on it.
I propose to close this RP for now (and retry quietly later).
@szaimen @ChristophWurst

[szaimen]

Let me try one thing. If that does not work we can revert this change.

[Jerome-Herbinet]

Note also that the problem could be the same in nextcloud/server#38338 event if styles are elsewhere.

[szaimen]

This fixes the problem in my testing: #4134

Let me know if it also for you :)