Files : Left panel dropdown improvement for NC 25

[Jerome-Herbinet]

• Resolves: Invisible drop down button on left panel #38155

(from @Clementine46)

/!\ Testing is welcome in order to make sure it's not doing side effects elsewhere in the UI.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[szaimen]

Hi @Jerome-Herbinet do you have a before - after screenshot?

[Jerome-Herbinet]

Hi @Jerome-Herbinet do you have a before - after screenshot?

@szaimen

Before :

before.2.webm

After :

after.2.webm

[Jerome-Herbinet]

@szaimen
I noticed that things have changed in Nextcloud 26 in comparison with Nextcloud 25. So I did an equivalent PR for Nextcloud 26 in /nextcloud/nextcloud-vue which is nextcloud-libraries/nextcloud-vue#4103
So milestone 28 or 27 ;-) ... might be applied on the other PR but not on this one.

[szaimen]

@Jerome-Herbinet I think this PR should target the stable25 branch then instead of master, no?

[Jerome-Herbinet]

@Jerome-Herbinet I think this PR should target the stable25 branch then instead of master, no?

Yes you are right. I'll look how to do it ; is it possible to target another branch without doing a new PR ?

[szaimen]

Yes you are right. I'll look how to do it ; is it possible to target another branch without doing a new PR ?

You can use the cherry-pick feature of git for this

[Jerome-Herbinet]

Yes you are right. I'll look how to do it ; is it possible to target another branch without doing a new PR ?

You can use the cherry-pick feature of git for this

Impossible, I got this :

Enumerating objects: 17, done.
Counting objects: 100% (17/17), done.
Delta compression using up to 8 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 29.94 KiB | 696.00 KiB/s, done.
Total 9 (delta 5), reused 3 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (5/5), completed with 5 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/stable25.
remote: error: At least 2 approving reviews are required by reviewers with write access. 13 of 13 required status checks are expected.
To https://github.com/nextcloud/server.git
! [remote rejected] stable25 -> stable25 (protected branch hook declined)
error: failed to push some refs to 'https://github.com/nextcloud/server.git'

[szaimen]

You need to create a copy branch from stable25 and then cherry pick to that one...

[jancborchardt]

Nice tackling this @Jerome-Herbinet! Design feedback:

• Shouldn't this use an actual action button component on the right if the entry, also for accessibility?
• The arrow pointing to the right by default looks a bit strange. By default it should point down to indicate a dropdown. When opened, it can point up (or still pointing down is also fine).

[szaimen]

Also blocking since this needs to target thr stable25 branch

[Jerome-Herbinet]

I close this PR and have created a new one on stable25 branch #38338
@juliushaertl @jancborchardt