Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-expanded to settings accordion button #4109

Merged
merged 1 commit into from May 17, 2023
Merged

Add aria-expanded to settings accordion button #4109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions l10n/messages.pot
View file
Open in desktop
Expand Up @@ -143,6 +143,9 @@ msgstr ""
msgid "Open navigation"
msgstr ""

msgid "Open settings menu"
msgstr ""

msgid "Password is secure"
msgstr ""

Expand Down
6 changes: 6 additions & 0 deletions src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue
View file
Open in desktop
Expand Up @@ -27,6 +27,9 @@
<div id="app-settings__header">
<button class="settings-button"
type="button"
:aria-expanded="open ? 'true' : 'false'"
aria-controls="app-settings__content"
:aria-label="ariaLabel"
@click="toggleMenu">
<Cog class="settings-button__icon" :size="20" />
<span class="settings-button__label">{{ title }}</span>
Expand Down Expand Up @@ -77,6 +80,9 @@ export default {
this.clickOutsideOptions,
]
},
ariaLabel() {
return t('Open settings menu')
},
},
methods: {
toggleMenu() {
Expand Down