Add aria-expanded to settings accordion button #4109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
added
the
accessibility
Fenn-CS
force-pushed
the
nextcloud/server/37136/add-aria-expanded-to-settings-button
branch
from
223d38d
to
b9829ab
Compare
artonge
approved these changes
May 15, 2023
susnux
reviewed
May 15, 2023
src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue
Outdated
Show resolved
Hide resolved
Fenn-CS
force-pushed
the
nextcloud/server/37136/add-aria-expanded-to-settings-button
branch
2 times, most recently
from
1ca5722
to
484635d
Compare
susnux
approved these changes
May 17, 2023
raimund-schluessler
requested changes
May 17, 2023
src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue
Outdated
Show resolved
Hide resolved
Fenn-CS
force-pushed
the
nextcloud/server/37136/add-aria-expanded-to-settings-button
branch
from
484635d
to
06be3b9
Compare
src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue
Outdated
Show resolved
Hide resolved
Fenn-CS
force-pushed
the
nextcloud/server/37136/add-aria-expanded-to-settings-button
branch
from
06be3b9
to
b31fc57
Compare
src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue
Outdated
Show resolved
Hide resolved
Mark settings button that triggers the expand/collaps of the side nav settings with aria-expanded attribute to improve accesibility. Resolves : nextcloud/server#37136 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
nextcloud/server/37136/add-aria-expanded-to-settings-button
branch
from
b31fc57
to
12ee9d4
Compare
raimund-schluessler
approved these changes
May 17, 2023
raimund-schluessler
deleted the
nextcloud/server/37136/add-aria-expanded-to-settings-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark settings button that triggers the expand/collaps of the side nav settings with aria-expanded attribute to improve accesibility.
Resolves : nextcloud/server#37136