Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focus-visible style for NcCheckboxRadioSwitch #4176

Merged
merged 1 commit into from Jun 9, 2023

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Jun 2, 2023

Improve accesibility by making focus indicator visible.

Resolves : nextcloud/photos#1671

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
7f1a8522565d214125291c78487d02e1 Screenshot from 2023-06-09 16-59-51

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • πŸ“˜ Component documentation has been extended, updated or is not applicable

@Fenn-CS Fenn-CS added the accessibility Making sure we design for the widest range of people possible, including those who have disabilities label Jun 2, 2023
@Fenn-CS Fenn-CS force-pushed the add-noticeable-focus-to-nc-checkboxradioswitch branch from d82a8da to fa8c137 Compare June 6, 2023 00:49
@Fenn-CS Fenn-CS marked this pull request as ready for review June 6, 2023 00:52
@Fenn-CS Fenn-CS requested review from susnux, skjnldsv, Pytal and szaimen and removed request for susnux June 6, 2023 00:52
@Fenn-CS Fenn-CS force-pushed the add-noticeable-focus-to-nc-checkboxradioswitch branch from fa8c137 to ea9c8ba Compare June 7, 2023 00:35
@Fenn-CS Fenn-CS requested a review from skjnldsv June 7, 2023 00:36
@skjnldsv
Copy link
Contributor

skjnldsv commented Jun 7, 2023

Awesome @Fenn-CS :)

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Jun 7, 2023
@Fenn-CS Fenn-CS requested a review from artonge June 8, 2023 22:30
Improve accesibility by making focus indicator visible.

Resolves : nextcloud/photos#1671

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS Fenn-CS force-pushed the add-noticeable-focus-to-nc-checkboxradioswitch branch from ea9c8ba to 5ef76b3 Compare June 9, 2023 16:04
@Fenn-CS Fenn-CS merged commit d9db4d5 into master Jun 9, 2023
16 checks passed
@Fenn-CS Fenn-CS deleted the add-noticeable-focus-to-nc-checkboxradioswitch branch June 9, 2023 18:42
@skjnldsv skjnldsv mentioned this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities
Projects
None yet
5 participants