Fix: Leftovers of name prop migration + fix @ in user ids (richEditor)
#4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
susnux
requested review from
nickvergessen,
raimund-schluessler,
julien-nc and
a team
susnux
force-pushed
the
fix/menu-bubble-at-in-user-name
branch
from
4e92aae
to
23c8ab6
Compare
| @@ -51,7 +51,7 @@ export default { | |||
| name: 'NcAutoCompleteResult', | |||
|
|
|||
| props: { | |||
| label: { | |||
| title: { | |||
There was a problem hiding this comment.
This change was intentional, because we agreed to use the term title only if if relates to the HTML attribute title, which it does not here.
Is there a deeper problem with renaming the prop here?
There was a problem hiding this comment.
Yes, the problem was that the property of the menububble was renamed from label to title, but the menububble and the autocompleteresult share the same data.
Also I think that in this case title is the more logical name for this property usage.
nickvergessen
requested review from
Antreesy
and removed request for
nickvergessen
marcoambrosini
approved these changes
Jun 23, 2023
Antreesy
reviewed
Jun 26, 2023
…bel` to `title` * Also fix the mixin to allow `@` within userids Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/menu-bubble-at-in-user-name
branch
from
23c8ab6
to
cb532ca
Compare
|
@Antreesy nice! Add the title prop :) |
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
titleprops and slots toname#4106The first commit solves some issues / leftovers where the property was renamed but the example code was not changed.
The second commit solves an issues were mentioning users with
@in there userid was not possible (@was removed).Also added a note about the property renaming on the changelog previously only
name->titlewas mentioned and notlabel->title.New tests included.
🖼️ Screenshots
🏁 Checklist