Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcRichContenteditable): bring back label for autocomplete #5215

Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Feb 5, 2024

☑️ Resolves

NcAutoComplete used in NcRichContenteditable had props that were in line with server API response for mentions.

In that PR label was renamed to title. not it is not possible to use mentions API resopnse without data mapping.

For example, in Talk nextcloud/spreed@ea667ff a work around was added:

https://github.com/nextcloud/spreed/blob/ea667ff6e1b9ae8515bd55b8d499a316b6dfe25f/src/components/NewMessage/NewMessage.vue#L709-L712

// TODO fix backend for userMention
if (!possibleMention.title && possibleMention.label) {
	possibleMention.title = possibleMention.label
}

While in server it was forgotten:

image

This PR brings back title prop and uses label as a fallback for light migration.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Feb 5, 2024
@ShGKme ShGKme added this to the 8.6.2 milestone Feb 5, 2024
@ShGKme ShGKme self-assigned this Feb 5, 2024
@ShGKme ShGKme force-pushed the fix/nc-rich-contenteditable--autocomplete-props branch 2 times, most recently from f4e91fd to 5103725 Compare February 5, 2024 20:08
@ShGKme ShGKme marked this pull request as ready for review February 5, 2024 20:09
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/nc-rich-contenteditable--autocomplete-props branch from 5103725 to 52beddf Compare February 5, 2024 20:24
@ShGKme
Copy link
Contributor Author

ShGKme commented Feb 5, 2024

@susnux @raimund-schluessler Could you have a look tomorrow?

@JuliaKirschenheuter JuliaKirschenheuter merged commit 1eb84eb into master Feb 5, 2024
18 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/nc-rich-contenteditable--autocomplete-props branch February 5, 2024 20:28
@ShGKme ShGKme mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants