fix(NcModal): Close button should be visible even if modal content is scrolled

[susnux]

☑️ Resolves

• Fix Scrolled modal can't be closed #3118

Ensures that the close button of the modal is always visible, even if the content overflows the container and is scrolled.

🧪 Cypress test included.

🏁 Checklist

• ⛑️ Tests are included or are not applicable
• 📘 Component documentation has been extended, updated or is not applicable

[raimund-schluessler]

@susnux Awesome that you included tests, but Runner2 gives this error:

ERROR in /home/runner/actions-runner/_work/nextcloud-vue/nextcloud-vue/cypress/component/modal.cy.ts
./cypress/component/modal.cy.ts 2:20-62
[tsl] ERROR in /home/runner/actions-runner/_work/nextcloud-vue/nextcloud-vue/cypress/component/modal.cy.ts(2,21)
      TS2307: Cannot find module '../../src/components/NcModal/NcModal.vue' or its corresponding type declarations.

webpack 5.88.2 compiled with 1 error in 18184 ms


  NcModal
    ✓ close button is visible when content is scrolled (102ms)

However, it passes anyway, so I don't know what the error means 🙈

[susnux]

However, it passes anyway, so I don't know what the error means see_no_evil

It means Typescript is missing the type definitions for that vue file, as it is written in Javascript and we do not provide any typings for it. I think to silence that issue I will have to add a declaration shim for tests :)

[st3iny]

Tested in calendar and works.

Some hacks need to be reverted and I added a note to #4223.

Exemplary patch for calendar

diff --git a/css/app-settings.scss b/css/app-settings.scss
index 5e96ae0e6..5ae9a0744 100644
--- a/css/app-settings.scss
+++ b/css/app-settings.scss
@@ -86,8 +86,6 @@
 
 .shortcut-overview-modal {
 	.modal-container {
-		display: flex !important;
-		flex-wrap: wrap;
 		padding: 0 12px 12px 12px !important;
 
 		* {

[susnux]

/backport to stable7

[Antreesy]

After re-ordering of modal-container__close and modal-container__content content can overlap close button, making it inaccessible

Raised an issue 4627 for tracking this