Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcSelect): Use named export of VueSelect to prevent issues when imported in ESM projects #4451

Merged
merged 1 commit into from Aug 23, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 23, 2023

☑️ Resolves

TypeError: nextcloud_vue_select__WEBPACK_IMPORTED_MODULE_4_.props is undefined

With mixed exports the default is not imported but the whole exports object, can be tested with a simple script.
Just name this script some-name.mjs and run node ./some-name.mjs (of cause in that directory must be a node_modules with @nextcloud/vue-select installed).

import VueSelect from '@nextcloud/vue-select'
console.warn(VueSelect)

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

…mported in ESM projects

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working feature: select Related to the NcSelect* components labels Aug 23, 2023
@susnux susnux added this to the 8.0.0 milestone Aug 23, 2023
@susnux susnux added the 3. to review Waiting for reviews label Aug 23, 2023
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susnux susnux merged commit 51fa1c0 into master Aug 23, 2023
16 checks passed
@susnux susnux deleted the fix/vue-select branch August 23, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants