Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcSelect): Use named export of VueSelect to prevent issues when imported in ESM projects #4451

Merged
merged 1 commit into from Aug 23, 2023
Merged

fix(NcSelect): Use named export of VueSelect to prevent issues when imported in ESM projects #4451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/NcSelect/NcSelect.vue
View file
Open in desktop
Expand Up @@ -526,7 +526,7 @@
</template>

<script>
import VueSelect from '@nextcloud/vue-select'
import { VueSelect } from '@nextcloud/vue-select'
import '@nextcloud/vue-select/dist/vue-select.css'
import {
autoUpdate,
Expand Down Expand Up @@ -749,7 +749,7 @@
/**
* Array of options
*
* @type {Array<string | number | { [key: string | number]: any }>}

Check warning on line 752 in src/components/NcSelect/NcSelect.vue

View workflow job for this annotation

GitHub Actions / eslint 

Syntax error in type: Array<string | number | { [key: string | number]: any }>
*
* @see https://vue-select.org/api/props.html#options
*/
Expand Down Expand Up @@ -804,7 +804,7 @@
*
* The `v-model` directive may be used for two-way data binding
*
* @type {string | number | { [key: string | number]: any } | Array<any>}

Check warning on line 807 in src/components/NcSelect/NcSelect.vue

View workflow job for this annotation

GitHub Actions / eslint 

Syntax error in type: string | number | { [key: string | number]: any } | Array<any>
*
* @see https://vue-select.org/api/props.html#value
*/
Expand Down