Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcEmojiPicker): Set type to native for selected emoji #4575

Merged
merged 1 commit into from Sep 26, 2023

Conversation

mejo-
Copy link
Contributor

@mejo- mejo- commented Sep 26, 2023

The default is to display the emoji from a remote data source, which we don't want (and is prohibitted by our CSP anyway).

I tested this while implementing nextcloud/collectives#422.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

The default is to display the emoji from a remote data source, which we
don't want (and is prohibitted by our CSP anyway).

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added bug Something isn't working 3. to review Waiting for reviews labels Sep 26, 2023
@mejo-
Copy link
Contributor Author

mejo- commented Sep 26, 2023

/backport to stable7

@mejo- mejo- merged commit 77ca1e0 into master Sep 26, 2023
15 checks passed
@mejo- mejo- deleted the fix/emojipicker_selected_native branch September 26, 2023 14:50
@mejo-
Copy link
Contributor Author

mejo- commented Sep 26, 2023

Manual backport to stable7: #4579

@Pytal Pytal mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants