[NcAppSettingsDialog] Allow to add icons to the navigation sections #4745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
This consists of 2 commits, the first one changes the way the sections are registered and the second on provides icon support.
Section registration
Previously the default slot content was iterated and the props of every vNode were used. This had two downsides:
$slots
is not reactive -> changes will not propagateSo instead we now provide to functions to children:
registerSection
andunregisterSection
with that functions children (the sections) can register themself and update on change. Solving both issues: the reactivity and the ability to inject icons (as the registration is done after mount).I personally also think it is easier to understand as no longer internals of vNodes need to be handled, but this is personal taste.
Icon support
There is a new slot
icon
on the settings section which allows to inject icons to the section name in the navigation.🖼️ Screenshots
With this changes it loos like this:
🏁 Checklist