fix(NcAppSettingsDialog): issues on register/unregister sections #4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
…emoving Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
`indexOf` searched by value, not by callback Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/nc-app-settings-dialog--register-unregister
branch
from
c5675b6
to
52d62b9
Compare
3 tasks
|
Closed in flavor of #4798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Fixes a number of typos in
NcAppSettingsDialog🖼️ Screenshots
🚧 Tasks
registerSectionwas provided asunregisterSectionunregisterSectionfiltered all items except the one that was supposed to be removedindexOfsearches for a value, not by a callbackselectedSectiononregisterSection/unregisterSection🏁 Checklist