Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActions): provide aria-expanded="false" when menu is closed instead of removing it #4946

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix(NcActions): provide aria-expanded="false" when menu is closed instead of removing it #4946

merged 1 commit into from
Dec 12, 2023

Commits on Dec 11, 2023

  1. fix(NcActions): provide aria-expanded="false" when menu is closed 

    Example on [w3c patterns](https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions/) says
"The aria-expanded attribute is removed when the menu is closed.".

However there is an ongoing discussion about it.
For example, PR 2829 on https://github.com/w3c/aria-practices/pull/.
Or another example https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/

So actually it is recommended to add `aria-expanded="false"`, not remove the attribute.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
    @ShGKme
    ShGKme committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    9408082 View commit details
    Browse the repository at this point in the history