fix(NcActions): provide aria-expanded="false" when menu is closed instead of removing it
#4946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example on [w3c patterns](https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions/) says "The aria-expanded attribute is removed when the menu is closed.". However there is an ongoing discussion about it. For example, PR 2829 on https://github.com/w3c/aria-practices/pull/. Or another example https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/ So actually it is recommended to add `aria-expanded="false"`, not remove the attribute. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
added
bug
szaimen
approved these changes
Dec 11, 2023
susnux
approved these changes
Dec 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Example on w3c patterns says "The aria-expanded attribute is removed when the menu is closed.".
However there is an ongoing discussion about it.
For example, PR 2829 on https://github.com/w3c/aria-practices/pull/. Or another example https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/
So actually it is recommended to add
aria-expanded="false", not remove the attribute.🏁 Checklist