Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcDialog): allow to close NcDialog on click outside #5062

Merged
merged 1 commit into from Jan 12, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🚧 Tasks

  • Alternative: make closeOnClickOutside true by default ?

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

… outside

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@Antreesy Antreesy merged commit fa70e03 into master Jan 12, 2024
15 checks passed
@Antreesy Antreesy deleted the fix/noid/click-outside-nc-dialog branch January 12, 2024 14:13
@susnux
Copy link
Contributor

susnux commented Jan 13, 2024

Alternative: make closeOnClickOutside true by default

I would say no for the filepicker we had this discussion somewhere. The close button is always visible - even if scrolled - on NcDialogs so users can explicitly close it. This prevents erroneous aborting just because of clicking a bit too far outside.

And I think it really depends on the content of your dialog, a simple confirmation might be dismissed by click outside, while something like a user creation dialog might lead to data loss and frustration just because of an accidental click (e.g. while trying to click "submit" or "accept" - so if the dialog backdrop is not inert we probably need more padding around buttons to allow all users to have frustration free UX).

@Pytal Pytal mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: dialog Related to the dialog component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants