fix(a11y): make datepicker more accessible #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A finding of an a11y test on a project, where the Datepicker is used, was that the proposed columnheader role is missing, thus making the datepicker not accessible for blind users.
qub1t
changed the title
|
Hey @qub1t Would you mind showing us a link to the documentation referring |
Codecov Report
@@ Coverage Diff @@
## master #3343 +/- ##
==========================================
+ Coverage 87.99% 90.88% +2.88%
==========================================
Files 94 95 +1
Lines 2741 2743 +2
Branches 510 510
==========================================
+ Hits 2412 2493 +81
+ Misses 268 190 -78
+ Partials 61 60 -1
Continue to review full report at Codecov.
|
|
Sure. This is where I found it. https://www.w3.org/TR/wai-aria-1.1/#grid |
|
Oh yes you're right! I completely forgot our datepicker was set to be |
|
Thanks @qub1t for your contribution! |
qub1t
added a commit
to qub1t/ng-bootstrap
that referenced
this pull request
Sep 5, 2019
After the addition of ```role="columnheader"``` (ng-bootstrap#3343), the parent div needs role="row", just like all consecutive sibling divs
This was referenced Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A finding of an a11y test on a project, where the Datepicker is used, was that the proposed columnheader role is missing, thus making the datepicker not accessible for blind users.
Before submitting a pull request, please make sure you have at least performed the following: