fix(a11y): missing role=row #3350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A finding of an a11y test on a project, where the Datepicker is used, was that the proposed columnheader role is missing, thus making the datepicker not accessible for blind users.
After the addition of ```role="columnheader"``` (ng-bootstrap#3343), the parent div needs role="row", just like all consecutive sibling divs
fix(a11y): missing role=row
Codecov Report
@@ Coverage Diff @@
## master #3350 +/- ##
=======================================
Coverage 90.88% 90.88%
=======================================
Files 95 95
Lines 2743 2743
Branches 510 510
=======================================
Hits 2493 2493
Misses 190 190
Partials 60 60
Continue to review full report at Codecov.
|
benouat
requested changes
Sep 10, 2019
There was a problem hiding this comment.
Hey @qub1t could you address my below comment in the review?
The change is so small that ideally this PR should only have a single commit, with a single change, only the missing role="row"... Maybe the easiest way would be to close that PR, and re-open a new one 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the addition of
role="columnheader"(#3343), the parent div needs role="row", just like all consecutive sibling divsBefore submitting a pull request, please make sure you have at least performed the following: