Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): missing role=row #3350

Closed
wants to merge 4 commits into from
Closed

fix(a11y): missing role=row #3350

wants to merge 4 commits into from

Commits on Aug 29, 2019

  1. make datepicker more accessible

    A finding of an a11y test on a project, where the Datepicker is used, was that the proposed columnheader role is missing, thus making the datepicker not accessible for blind users.
    qub1t committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    fc84c8c View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. fix(a11y): missing role=row

    After the addition of ```role="columnheader"``` (ng-bootstrap#3343), the parent div needs role="row", just like all consecutive sibling divs
    qub1t committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    be09ecc View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from qub1t/a11y-role

    fix(a11y): missing role=row
    qub1t committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    1fb1789 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Configuration menu
    Copy the full SHA
    4dcf483 View commit details
    Browse the repository at this point in the history