fix(modal): ignore accidental backdrop clicks #3457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a combination of 'mousedown/up' events instead of 'click'. This aligns behavior with bootstrap and helps with closing modal accidentally (ex. when selecting text) Some tests had to be converted to e2e Closes ng-bootstrap#3384 Fixes ng-bootstrap#1950
Codecov Report
@@ Coverage Diff @@
## master #3457 +/- ##
==========================================
- Coverage 91.18% 91.12% -0.07%
==========================================
Files 95 95
Lines 2790 2793 +3
Branches 517 516 -1
==========================================
+ Hits 2544 2545 +1
- Misses 189 190 +1
- Partials 57 58 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a combination of 'mousedown/up' events instead of 'click'.
Aligns behavior with bootstrap and helps with closing modal accidentally (ex. when selecting text)
Some tests had to be converted to e2e
Closes #3415
Fixes #1950