Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): ignore accidental backdrop clicks #3457

Merged
merged 1 commit into from
Nov 8, 2019
Merged

fix(modal): ignore accidental backdrop clicks #3457

merged 1 commit into from
Nov 8, 2019

Commits on Nov 8, 2019

  1. fix(modal): ignore accidental backdrop clicks 

    This uses a combination of 'mousedown/up' events instead of 'click'.
This aligns behavior with bootstrap and helps with closing modal accidentally (ex. when selecting text)

Some tests had to be converted to e2e

Closes ng-bootstrap#3384
Fixes ng-bootstrap#1950
    @maxokorokov
    maxokorokov committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    863d068 View commit details
    Browse the repository at this point in the history