feat(datepicker): change 'select' event to 'dateSelect' #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterblazejewicz
force-pushed
the
fix/3444
branch
from
7a749c0
to
97bb372
Compare
Codecov Report
@@ Coverage Diff @@
## master #3461 +/- ##
==========================================
+ Coverage 91.59% 91.59% +<.01%
==========================================
Files 100 100
Lines 2867 2868 +1
Branches 527 527
==========================================
+ Hits 2626 2627 +1
Misses 183 183
Partials 58 58
Continue to review full report at Codecov.
|
maxokorokov
requested changes
Nov 14, 2019
There was a problem hiding this comment.
Hey, @peterblazejewicz!
Thanks for the PR, just left one comment.
src/datepicker/datepicker-service.ts
Outdated
| get dateSelect$(): Observable<NgbDate> { return this._dateSelect$.pipe(filter(date => date !== null)); } | ||
|
|
||
| /** @deprecated please use `dateSelect$` */ | ||
| get select$(): Observable<NgbDate> { return this.dateSelect$; } |
There was a problem hiding this comment.
This should be removed, not deprecated because NgbDatepickerService is the internal implementation. I'd say either:
- don't rename
_select$andget select()at all, because it's internal (I think I prefer this personally) - or remove this deprecation completely, because it should not be used anywhere anyway
This commit changes name of the component custom event to avoid conflicts with native 'select' event. Existing event name will be marked as deprecated in v6. Fixes ng-bootstrap#3444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes name of the component custom event to avoid
conflicts with native 'select' event.
Existing event name is marked as deprecated for backward compatibility.
Fixes #3444
Thanks!