Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datepicker): change 'select' event to 'dateSelect' #3461

Merged
merged 2 commits into from Jan 9, 2020
Merged

feat(datepicker): change 'select' event to 'dateSelect' #3461

merged 2 commits into from Jan 9, 2020

Commits on Jan 9, 2020

  1. feat(datepicker): introduce 'dateSelect' event to replace 'select' 

    This commit changes name of the component custom event to avoid
conflicts with native 'select' event.

Existing event name will be marked as deprecated in v6.

Fixes ng-bootstrap#3444
    @peterblazejewicz @maxokorokov
    peterblazejewicz authored and maxokorokov committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    4fec3db View commit details
    Browse the repository at this point in the history

  2. chore: cleanup datepicker (select) deprecation

    @maxokorokov
    maxokorokov committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    14d59b3 View commit details
    Browse the repository at this point in the history