ci(test): use a single test job that we can require, independent of…

… test matrix (#2581)
nock · Feb 3, 2024 · ad8c80e · ad8c80e
1 parent 7468cf1
commit ad8c80e
Showing 1 changed file with 34 additions and 15 deletions.
diff --git a/.github/workflows/continuous-integration.yaml b/.github/workflows/continuous-integration.yaml
@@ -63,9 +63,26 @@ jobs:
       - name: Lint
         run: |
           npm run lint:ts
-  test:
-    name: Test
+
+  # verify against ranges defined as supported in engines.node
+  test_matrix:
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version:
+          - 10
+          - 12
+          - 14
+          - 16
+          - 18
+        os:
+          - macos-latest
+          - ubuntu-latest
+          - windows-latest
+
     runs-on: ${{ matrix.os }}
+    timeout-minutes: 5
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -83,16 +100,18 @@ jobs:
       - name: Test jest
         run: npm run test:jest
         if: matrix.node-version >= 14
-    strategy:
-      fail-fast: false
-      matrix:
-        node-version:
-          - 10
-          - 12
-          - 14
-          - 16
-          - 18
-        os:
-          - macos-latest
-          - ubuntu-latest
-          - windows-latest
+
+  # separate job to set as required in branch protection,
+  # as the build names above change each time Node versions change
+  test:
+    runs-on: ubuntu-latest
+    needs:
+      - test_matrix
+    if: ${{ !cancelled() }}
+    steps:
+      - name: All matrix versions passed
+        if: ${{ !(contains(needs.*.result, 'failure')) }}
+        run: exit 0
+      - name: Some matrix version failed
+        if: ${{ contains(needs.*.result, 'failure') }}
+        run: exit 1