Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR touches a lot of files due to the
npm run lint
final commit. This is all done by prettier and eslint and should be safe.To see the changes without the auto-fixes, look at master...4f78356
Changes:
npm run lint
also auto-fix problems that ESLint findstsconfig.json
file so that VSCode (and anything else usingtsc
to check for errors) can do live code analysis and provide better tab completion. This doesn't touch anything else, it's just a single file.array.some()
invocations that used side-effects with their for loop equivalent (lint++ commit)npm run lint
ESLint finds more problems than JSHint, and integrating with Prettier is faster than having the two separately, plus it automatically disables ESLint rules related to formatting which is automated by Prettier.
The JSDoc plugin ensures that the JSDoc entries are consistently formatted, and helps with detecting unparseable descriptions (they won't format).
Merging this will cause open PRs to have merge conflicts. To fix those, there are two options:
master
, runningnpm run lint
after every merge conflict fixup (preferred for clean branches)npm run lint
and committing the result (easiest)