Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: install glib2-devel on centos7-ppc64 #2709

Merged
merged 2 commits into from Jul 13, 2021
Merged

Conversation

richardlau
Copy link
Member

V8 CI needs glib2-devel installed.

Also a commit to fix running in check mode.

Fixes: #2702
Refs: nodejs/node#39373 (comment)

Allow some `uri` tasks to run in check mode.
V8 CI needs `glib2-devel` installed.
@richardlau
Copy link
Member Author

richardlau commented Jul 13, 2021

This has been deployed on both

  • test-osuosl-centos7-ppc64_le-1 (no new packages installed)
  • test-osuosl-centos7-ppc64_le-2 (glib2-devel was installed)

Test V8 CI in progress on test-osuosl-centos7-ppc64_le-2: https://ci.nodejs.org/job/node-test-commit-v8-linux/4136/nodes=centos7-ppcle,v8test=v8test/ (✔️)

@richardlau
Copy link
Member Author

Test build on test-osuosl-centos7-ppc64_le-2 (where the V8 CI was previously failing) passed 🎉.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit fd42b53 into nodejs:master Jul 13, 2021
@richardlau richardlau deleted the ppc branch July 13, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is only one ppc64 machine with the v8test label
3 participants