v16.5.0 release proposal #39373
Merged
v16.5.0 release proposal #39373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actions interface has a better integration with GitHub, and with Annotations and Problem Matcher we can display all failed checks in a single place, so that users don't have to go through the logs to figure out what's wrong. Since the job on Travis was allowed to fail and is not as easy to read, remove it from our Matrix. The Action will check every commit in the Pull Request, skipping commits with "fixup" or "squash". PR-URL: #32417 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
The commit linter was checking out the PR HEAD commit instead of merge/rebase commit, causing it to fail for any PRs that were not rebased on our default branch. Removing `ref` should fix the issue. PR-URL: #39121 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #39113 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
V8's test-runner dropped the `--mode` argument some time back, and now produces the following error if run with it: run-tests.py: error: no such option: --mode PR-URL: #39055 Refs: #35705 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fix the napi_default_jsproperty flag of the napi_property_attributes enum that was incorrectly referred to as napi_default_property. Signed-off-by: Davidson Francis <davidsondfgl@gmail.com> PR-URL: #39104 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
On Windows there is a limit to the length of commands, so there will be an error once the lengths of the JS file names combined exceed that limit. This patch modifies js2c.py so that it now takes a --directory argument to glob for .js and .mjs files in addition to the list of files passed directly. We still pass the additional files we include from deps/ directly through the command line, as we only includes some of them so we cannot simply glob, but those are limited so listing them out should be fine. Refs: https://docs.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation PR-URL: #39069 Refs: #38971 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #39043 Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Adding a return when it's not really a getter is kind of misleading, but so is using a getter for something that doesn't return anything, so ¯\_(ツ)_/¯. PR-URL: #39078 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #39082 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
PR-URL: #39127 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The `wasi` lib module's `initialize()` method is missing a validator. PR-URL: #39070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
The `fs` lib module's `mkdtemp()` and `mkdtempSync()` methods were missing a validator, and weren't allowing the empty string as a valid prefix. PR-URL: #39028 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Refs: https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md PR-URL: #39032 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #39170 Refs: nodejs/remark-preset-lint-node#188 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #39105 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
- Move Performance and InternalPerformance to a new lib/internal/perf/performance.js - Move now() getMilestoneTimestamp() into lib/internal/perf/utils.js - Rename lib/internal/perf/perf.js to lib/internal/perf/performance_entry.js - Refresh time origin at startup (this means the time origins could differ between snapshot building time and snapshot creation time) PR-URL: #38971 Refs: #35711 Reviewed-By: James M Snell <jasnell@gmail.com>
When I moved node-inspect into core, I called a lot of things `inspector-cli` that really should have been `debugger`. This is the last of them to be renamed. PR-URL: #39156 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Stick with "repository" instead of using both "repository" and "repo". PR-URL: #39157 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Logic in module_job.js assumes detailed stack trace from node_errors.cc which is not populated when --enable-source-maps is set. Fixes #38790 PR-URL: #39017 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: nodejs/remark-preset-lint-node#188 PR-URL: #39165 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
PR-URL: #39138 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
We can remove the Acorn plugins as their features are now supported by default. PR-URL: #39166 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #39148 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
@nodejs/platform-ppc Can you please help about this error: https://ci.nodejs.org/job/node-test-commit-v8-linux/4134/nodes=centos7-ppcle,v8test=v8test/console |
targos
added
release
|
@richardlau try installing |
The machines are running centos7 -- the missing package was |
tniessen
approved these changes
Jul 13, 2021
richardlau
approved these changes
Jul 13, 2021
BethGriggs
approved these changes
Jul 13, 2021
|
Isn't it too late to squash this #39134 in? 😃 |
|
I updated "npm-robot" to "npm team" in the changelog (npm/cli#3541) |
|
Release build: https://ci-release.nodejs.org/job/iojs+release/7032/ |
targos
added a commit
that referenced
this pull request
Jul 14, 2021
targos
added a commit
to targos/nodejs.org
that referenced
this pull request
Jul 14, 2021
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-07-14, Version 16.5.0 (Current), @targos
Notable Changes
Experimental Web Streams API
Node.js now exposes an experimental implementation of the
Web Streams API.
While it is experimental, the API is not exposed on the global object and is only
accessible using the new
stream/webcore module:Importing the module will emit a single experimental warning per process.
The raw API is implemented and we are now working on its integration with
various existing core APIs.
Contributed by James M Snell - #39062
Other notable changes
83f3b959f9] - (SEMVER-MINOR) fs: allow empty string for temp directory prefix (Voltrex) #39028c04fd2bb97] - deps: upgrade npm to 7.19.1 (npm-robot) #39225Commits
aafa08d7b9] - bootstrap: load perf_hooks eagerly during bootstrap (Joyee Cheung) #389716e46eb186c] - bootstrap: support perf hooks in snapshot (Joyee Cheung) #3897110681828ac] - build: update gcovr for gcc 8 compatibility (Richard Lau) #393268381132f76] - build: add riscv into host_arch_cc (Lu Yahan) #39004a7ba21864d] - build: restore libplatform headers in distribution (Jeroen Ooms) #3928841161eabf2] - build: remove unused comment in Makefile (LitoMore) #39171f6a1092471] - build: allow to build riscv64 using Makefile (Makoto Kato) #39048a7cd40ed8d] - build: uvwasi honours node_shared_libuv (Jérémy Lal) #392603ed04994b7] - build: shorten path used in tarball build workflow (Richard Lau) #3919265b56b3774] - build: fix building with external builtins (Momtchil Momtchev) #39091412b1012d2] - build: pass directory instead of list of files to js2c.py (Joyee Cheung) #39069171ca6bb3c] - build: don't pass--modeargument to V8 test-runner (Richard Lau) #39055cf8536ea3f] - build: fix commit linter on unrebased PRs (Mary Marchini) #39121cf0533b8b2] - build: use Actions to validate commit message (Mary Marchini) #324174202274851] - crypto: move OPENSSL_IS_BORINGSSL guard (Shelley Vohr) #3913689f5a73ba5] - crypto: use compatible ecdh function (Shelley Vohr) #3905430e878b603] - crypto: add OPENSSL_IS_BORINGSSL guard (Shelley Vohr) #39138630266cba2] - debugger: indicate server is ending (Rich Trott) #3933448d9680f84] - debugger: remove final lint exceptions in inspect_repl.js (Rich Trott) #390784507714f9d] - deps: V8: backport 5c76da8ddcf8 (Michaël Zasso) #393370e64bd0dd6] - deps: V8: cherry-pick 359d44df4cdd (Michaël Zasso) #39337142ce6838b] - deps: V8: cherry-pick 3805a698f7b6 (Michaël Zasso) #393372657c305cb] - deps: V8: cherry-pick 56fe020eec0c (Michaël Zasso) #393375c5a93e533] - deps: V8: cherry-pick 2b77ca200c56 (Michaël Zasso) #39337cf49ebb052] - deps: V8: cherry-pick 53784bdb8f01 (Michaël Zasso) #393373d351b29c1] - deps: V8: cherry-pick cb4faa902e9f (Michaël Zasso) #39337165130a3e0] - deps: patch V8 to 9.1.269.38 (Michaël Zasso) #39196c04fd2bb97] - deps: upgrade npm to 7.19.1 (npm-robot) #39225bf4c50f9d9] - deps: upgrade npm to 7.19.0 (npm-robot) #391488630b39376] - deps: update Acorn to v8.4.1 (Michaël Zasso) #3916638ae4077c7] - doc: fix typos in Web Streams API documentation (Tobias Nießen) #39351fb6616ecbb] - doc: add text about moving long commit lists out of PR description (Danielle Adams) #3918629c9cc8f03] - doc: do not use & for "and" in text (Rich Trott) #393450b3b2695bc] - doc: do not use tilde for "about" or "approximately" (Rich Trott) #3934464a185e595] - doc: use consistent abbreviation formatting (Rich Trott) #393432573bf5116] - doc: update AUTHORS (Rich Trott) #3927763b6084724] - doc: put information about the past in details tags (Rich Trott) #39321e26635085a] - doc: replace outdatedutil.promisifytimer examples with references (foxxyz) #39164d101a85e36] - doc: move AndreasMadsen to emeritus (Rich Trott) #393152d552a32d6] - doc: move ofrobots to collaborator emeritus (Rich Trott) #39307131d676f64] - doc: simplify CRAN mirror text in benchmark guide (Rich Trott) #39287c92b80e631] - doc: use "repository" instead of "repo" in onboarding.md (Rich Trott) #3928681df9b1e92] - doc: update collaborator email address (Rich Trott) #39263b8860f35c9] - doc: remove GitHub mark (Rich Trott) #39251f06ebf1775] - doc: remove emailing the TSC from offboarding doc (Rich Trott) #39280175a6569f4] - doc: add annotation to writeFiledataasObject(Jacob) #391674d53c63c22] - doc: fix boldface punctuation for full sentences (Rich Trott) #39278146f733f43] - doc: fix constants usage in fs.access example (Cyrille Bourgois) #39289eacee0ab17] - doc: use "repository" in guides versus repo (Michael Dawson) #3919804bcfcfff1] - doc: update Node-api version matrix (Michael Dawson) #391974dd6ab389a] - doc: remove onboarding-extras (Rich Trott) #39252a01dacfdcd] - doc: move Sam Ruby to emeritus (Rich Trott) #392642bb3713b74] - doc: update AUTHORS file (Rich Trott) #392502227c1368f] - doc: fix color contrast for anchor marks in dark mode (Rich Trott) #39168f8cdaad9d4] - doc: rename datatypes to data types (FrankEntriken) #39209250024eaec] - doc: normalize CSS variable names and indentation (Rich Trott) #39199db74a35348] - doc: remove unnecessary module format comments (Rich Trott) #3921924a1f7ec84] - doc: use more consistent formatting for deprecations (Rich Trott) #3921824c0d7d872] - doc: update AUTHORS (Rich Trott) #392173e5ed72b0a] - doc: use "pull request" instead of "PR" in packages.md (Rich Trott) #39213ddc24b2105] - doc: move v8.stopCoverage() to expected location in doc (Rich Trott) #3921268c334c8c9] - doc: move vm.measureMemory() to expected location in doc (Rich Trott) #3921181d52d7c79] - doc: fix CHANGELOG.md formatting (Richard Lau) #392239c3a5fd53e] - doc: add cc oss-security@lists.openwall.com (Daniel Bevenius) #3919107ba2875ae] - doc: remove instructions for unsupported Node.js versions (Rich Trott) #39185482851f647] - doc: remove obsolete cc recommendations (Rich Trott) #391818311b29083] - doc: use "repository" in maintaining-V8 doc (Rich Trott) #39179952580e1bf] - doc: fix broken link in errors.md (Rich Trott) #39200af1e1dba36] - doc: correct JavaScript primitive value names in n-api.md (legendecas) #3912900728d1301] - doc: apply logical ordering to CSS variables (Rich Trott) #39169aec2744e14] - doc: remove file name from self-reference links (Antoine du Hamel) #3916574bb915178] - doc: use repository instead of repo (Rich Trott) #39157a669a191a1] - doc: use ASCII order for md refs (Antoine du Hamel) #3917021e8720155] - doc: fixEventTarget.dispatchEventdocs (Rohan Sharma) #3912790ec7660bc] - doc: update AUTHORS file (Rich Trott) #3908281cebec5cc] - doc: esm examples /w imports for process, Buffer (Guy Bedford) #39043c1588887a6] - doc: fix napi_default_property name (Davidson Francis) #39104a440f6c69c] - doc: fix dead links in packages.md (Michaël Zasso) #3911333cad271c5] - errors: remove eager stack generation for node errors (Gus Caplan) #39182ac05a0a8a3] - errors: don't throw TypeError on missing export (Benjamin Coe) #3901783f3b959f9] - (SEMVER-MINOR) fs: allow empty string for temp directory prefix (Voltrex) #39028ac7184d8c7] - http: clean up HttpParser correctly (Tobias Koppers) #3929235331cbd13] - http,https: align server option of https with http (Qingyu Deng) #3899229194d4f88] - inspector: move inspector async hooks to environment (Joyee Cheung) #39112ecf627a9af] - lib: rename TransferedReadableStream etc (Tobias Nießen) #393520e55cb72df] - lib: make lazyDOMException more common (Khaidi Chu) #39105cfd96aa8f9] - meta: fix tls code owners (Robert Nagy) #39355e5c2d80560] - meta: use form schema for bug report template (Michaël Zasso) #39194bd472daf0c] - meta: add @nodejs/actions as CODEOWNERS (Mary Marchini) #3911963f87027e3] - node-api: cctest on v8impl::Reference (legendecas) #389707ea98fbccd] - perf_hooks: refactor perf_hooks for snapshot building (Joyee Cheung) #3897120cc8ec2af] - readline: allow completer to rewrite existing input (Anna Henningsen) #39178b168ec2a2a] - repl: processTopLevelAwait fallback error handling (ejose19) #39290a101fe68ad] - repl: correctly hoist top level await declarations (ejose19) #39265d441d91450] - repl: ensure correct syntax err for await parsing (Guy Bedford) #391549184259a54] - src: add JSDoc typings for v8 (Voltrex) #3894466553feeba] - src: compare IPv4 addresses in host byte order (Colin Ihrig) #39096ea8d83bf59] - src,crypto: fix 0-length output crash in webcrypto (Khaidi Chu) #38913683c995001] - src,zlib: tighten up Z_*_WINDOWBITS macros (Khaidi Chu) #39115cb32f69e00] - stream: cleanup async handling (Robert Nagy) #393291fc6382942] - stream: don't emit prefinish after error or close (Robert Nagy) #3933235b6669e13] - stream: use finished for pump (Robert Nagy) #392039af62a1357] - (SEMVER-MINOR) stream: implement WHATWG streams (James M Snell) #390620bb980aeaf] - test: remove eslint-disable comment from fixture file (Rich Trott) #3932021f77031fb] - test: move debugger test case to parallel (Rich Trott) #393000ec93a1fc1] - test: use common.PORT instead of hardcoded port number (Rich Trott) #3929811a8b81caf] - test: remove debugger workaround for AIX (Rich Trott) #392968e77aa23f1] - test: add test for debugger restart message issue (Rich Trott) #3927313755599e1] - test: remove workaround code in debugger test (Rich Trott) #392381f31e3c774] - test: remove checks for armv6 (Rich Trott) #39162d486d0117c] - test: move test-debugger-address to parallel (Rich Trott) #39236cdc7a19f48] - test: remove common.enoughTestCpu (Rich Trott) #39161cc32365f56] - (SEMVER-MINOR) test: add WPT streams tests (James M Snell) #39062fff21a4afb] - test: replace "inspector-cli" with "debugger" (Rich Trott) #39156df17c62818] - test: use localhost test instead of connecting to remote (Adam Majer) #39011dfe99d2aac] - tls: move legacy code into own file (Robert Nagy) #39333f338fddbb0] - tools: add GitHub Action to run find-inactive-collaborators.mjs (Rich Trott) #39335b3a0dd1e4a] - tools: pass bot token to node-pr-labeler (Michaël Zasso) #39271b56a3d9009] - tools: update gyp-next to v0.9.3 (Jiawen Geng) #392913cd9f5e298] - tools: add find-inactive-collaborators.js (Rich Trott) #392620673ede3ad] - tools: take ownership of deps/v8/tools/node (Michaël Zasso) #39222cb8c6ffbce] - tools: update ESLint to 7.30.0 (Colin Ihrig) #39242d5113f9e34] - tools: remove armv6 from test tools (Rich Trott) #39162802d9c4488] - tools: update path-parse to 1.0.7 (Rich Trott) #39232ab9ccd014c] - tools: remove unusedlint-pr-commit-message.sh(Richard Lau) #391206200f3b35f] - tools: update @babel/eslint-parser to 7.14.7 (Rich Trott) #39160dfe5d1139c] - tools: update remark-preset-lint-node to 2.4.1 (Rich Trott) #392014715105581] - tools: upgradehighlight.jsto version 11.0.1 (Antoine du Hamel) #390322481ddd08d] - tools,doc: fix error message for unrecognized type (Antoine du Hamel) #39221adb812c042] - typings: add a few JSDoc typings for the net lib module (nerdthatnoonelikes) #3895329673b8ac8] - typings: add JSDoc typings for timers (Voltrex) #38834fe1c81f247] - wasi: use missing validator (Voltrex) #39070